-
Notifications
You must be signed in to change notification settings - Fork 344
chore: update operator-sdk version to 1.32 #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update operator-sdk version to 1.32 #742
Conversation
|
Skipping CI for Draft Pull Request. |
|
@anandrkskd: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Anand Kumar Singh <[email protected]>
2f57547 to
c68112e
Compare
|
We also need to pull in the latest |
Signed-off-by: Anand Kumar Singh <[email protected]>
|
In test/e2e/suite_test.go and test/nondefaulte2e/suite_test.go , please update the CRDDirectoryPaths to []string{filepath.Join("..", "..", "config", "crd", "bases")}, |
I am planning to do the |
Signed-off-by: Anand Kumar Singh <[email protected]>
saumeya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sounds good. Looks like we also need to update operator-sdk version in openshift-ci configs. I see one reference here :
@varshab1210 are there any other places where operator-sdk version is hardcoded, maybe in openshift/release repo? |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* update operator-sdk version to 1.32 Signed-off-by: Anand Kumar Singh <[email protected]> * fix: usign controller-gen 1.14.0 Signed-off-by: Anand Kumar Singh <[email protected]> * fix: test, CRD filepath Signed-off-by: Anand Kumar Singh <[email protected]> --------- Signed-off-by: Anand Kumar Singh <[email protected]>
What type of PR is this?
/kind chore
What does this PR do / why we need it:
This PR upgrades the operator-sdk version to v1.32
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
Download the 1.32 operator-sdk binary, run make operator-sdk also move this to your $PATH. Then run the makefile targets to verify the upgrade.