Skip to content

Conversation

@anandrkskd
Copy link
Contributor

What type of PR is this?
/kind chore

What does this PR do / why we need it:
This PR upgrades the operator-sdk version to v1.32

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Download the 1.32 operator-sdk binary, run make operator-sdk also move this to your $PATH. Then run the makefile targets to verify the upgrade.

@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2024

@anandrkskd: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind chore

What does this PR do / why we need it:
This PR upgrades the operator-sdk version to v1.32

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Download the 1.32 operator-sdk binary, run make operator-sdk also move this to your $PATH. Then run the makefile targets to verify the upgrade.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@anandrkskd anandrkskd added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process. label Jul 11, 2024
Signed-off-by: Anand Kumar Singh <[email protected]>
@anandrkskd anandrkskd force-pushed the operator-sdk-upgrade branch from 2f57547 to c68112e Compare July 11, 2024 06:39
@anandrkskd anandrkskd marked this pull request as ready for review July 11, 2024 07:04
@openshift-ci openshift-ci bot requested review from jaideepr97 and jannfis July 11, 2024 07:05
@svghadi svghadi removed request for jaideepr97 and jannfis July 11, 2024 16:51
@svghadi
Copy link
Member

svghadi commented Jul 11, 2024

We also need to pull in the latest ArgoCD and NotificationsConfiguration CRD from https://github.com/argoproj-labs/argocd-operator/tree/master/config/crd/bases to https://github.com/redhat-developer/gitops-operator/tree/master/config/crd/bases and update argocd-operator commit to latest in go.mod.

Signed-off-by: Anand Kumar Singh <[email protected]>
@saumeya
Copy link
Member

saumeya commented Jul 15, 2024

In test/e2e/suite_test.go and test/nondefaulte2e/suite_test.go , please update the CRDDirectoryPaths to []string{filepath.Join("..", "..", "config", "crd", "bases")},

@anandrkskd
Copy link
Contributor Author

We also need to pull in the latest ArgoCD and NotificationsConfiguration CRD from https://github.com/argoproj-labs/argocd-operator/tree/master/config/crd/bases to https://github.com/redhat-developer/gitops-operator/tree/master/config/crd/bases and update argocd-operator commit to latest in go.mod.

I am planning to do the go.mod changes in next part of operator-sdk version upgrade 1.35

Signed-off-by: Anand Kumar Singh <[email protected]>
Copy link
Member

@saumeya saumeya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svghadi
Copy link
Member

svghadi commented Jul 15, 2024

I am planning to do the go.mod changes in next part of operator-sdk version upgrade 1.35

Sounds good. Looks like we also need to update operator-sdk version in openshift-ci configs. I see one reference here :

ARG OPERATOR_SDK_VERSION=1.22.2

@varshab1210 are there any other places where operator-sdk version is hardcoded, maybe in openshift/release repo?

@svghadi
Copy link
Member

svghadi commented Jul 15, 2024

/lgtm

@svghadi
Copy link
Member

svghadi commented Jul 15, 2024

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ef35961 into redhat-developer:master Jul 15, 2024
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
* update operator-sdk version to 1.32

Signed-off-by: Anand Kumar Singh <[email protected]>

* fix: usign controller-gen 1.14.0

Signed-off-by: Anand Kumar Singh <[email protected]>

* fix: test, CRD filepath

Signed-off-by: Anand Kumar Singh <[email protected]>

---------

Signed-off-by: Anand Kumar Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved kind/cleanup Categorizes issue or PR as related to cleaning up code, process. lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants