Skip to content

Conversation

@chetan-rns
Copy link
Member

@chetan-rns chetan-rns commented May 22, 2024

What type of PR is this?

/kind bug

What does this PR do / why we need it:

  • The reconciler doesn't properly update the existing plugin Deployment resource in the cluster. Instead, it tries to update the desired object leading to a reconciliation loop. Since the desired resource doesn't have the resource version and other metadata the resource gets updated triggering the loop.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested review from iam-veeramalla and jgwest May 22, 2024 13:06
@openshift-ci
Copy link

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chetan-rns. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest
Copy link
Member

jgwest commented May 23, 2024

/retest

@chetan-rns chetan-rns force-pushed the fix-plugin-update branch from 8c00572 to 2f7655f Compare May 23, 2024 12:16
@jgwest
Copy link
Member

jgwest commented May 23, 2024

/retest

        --- FAIL: kuttl/harness/1-074_validate_terminating_namespace_block (25.42s) 

plus 2 cluster flakes

@jgwest
Copy link
Member

jgwest commented May 24, 2024

/retest

cluster flakes AFAICT

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @chetan-rns!

@jgwest jgwest merged commit db3c6bd into redhat-developer:master May 24, 2024
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
…#711)

* fix: update the existing plugin deployment resource

Signed-off-by: Chetan Banavikalmutt <[email protected]>

* reconcile the deployment spec template

Signed-off-by: Chetan Banavikalmutt <[email protected]>

---------

Signed-off-by: Chetan Banavikalmutt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants