From 1f422d19dcfc6ebc4f2332deae489a3628f0364e Mon Sep 17 00:00:00 2001 From: Faisal Ahmed Date: Sat, 19 Feb 2022 15:21:03 +0600 Subject: [PATCH 1/2] make code reusable --- .idea/.gitignore | 8 ++++++++ .idea/event-loop.iml | 47 ++++++++++++++++++++++++++++++++++++++++++++ .idea/modules.xml | 8 ++++++++ .idea/php.xml | 43 ++++++++++++++++++++++++++++++++++++++++ .idea/vcs.xml | 6 ++++++ src/Timer/Timers.php | 18 +++++++++-------- 6 files changed, 122 insertions(+), 8 deletions(-) create mode 100644 .idea/.gitignore create mode 100644 .idea/event-loop.iml create mode 100644 .idea/modules.xml create mode 100644 .idea/php.xml create mode 100644 .idea/vcs.xml diff --git a/.idea/.gitignore b/.idea/.gitignore new file mode 100644 index 00000000..13566b81 --- /dev/null +++ b/.idea/.gitignore @@ -0,0 +1,8 @@ +# Default ignored files +/shelf/ +/workspace.xml +# Editor-based HTTP Client requests +/httpRequests/ +# Datasource local storage ignored files +/dataSources/ +/dataSources.local.xml diff --git a/.idea/event-loop.iml b/.idea/event-loop.iml new file mode 100644 index 00000000..0f3900f5 --- /dev/null +++ b/.idea/event-loop.iml @@ -0,0 +1,47 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/.idea/modules.xml b/.idea/modules.xml new file mode 100644 index 00000000..9102eb9f --- /dev/null +++ b/.idea/modules.xml @@ -0,0 +1,8 @@ + + + + + + + + \ No newline at end of file diff --git a/.idea/php.xml b/.idea/php.xml new file mode 100644 index 00000000..aea11b31 --- /dev/null +++ b/.idea/php.xml @@ -0,0 +1,43 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/.idea/vcs.xml b/.idea/vcs.xml new file mode 100644 index 00000000..94a25f7f --- /dev/null +++ b/.idea/vcs.xml @@ -0,0 +1,6 @@ + + + + + + \ No newline at end of file diff --git a/src/Timer/Timers.php b/src/Timer/Timers.php index 70adc132..87f8331a 100644 --- a/src/Timer/Timers.php +++ b/src/Timer/Timers.php @@ -58,10 +58,7 @@ public function cancel(TimerInterface $timer) public function getFirst() { // ensure timers are sorted to simply accessing next (first) one - if (!$this->sorted) { - $this->sorted = true; - \asort($this->schedule); - } + $this->ensureTimerAreSorted(); return \reset($this->schedule); } @@ -74,10 +71,7 @@ public function isEmpty() public function tick() { // ensure timers are sorted so we can execute in order - if (!$this->sorted) { - $this->sorted = true; - \asort($this->schedule); - } + $this->ensureTimerAreSorted(); $time = $this->updateTime(); @@ -104,4 +98,12 @@ public function tick() } } } + + private function ensureTimerAreSorted() + { + if (!$this->sorted) { + $this->sorted = true; + \asort($this->schedule); + } + } } From b26a12c03c164864d7f7e80145c85a13011ab196 Mon Sep 17 00:00:00 2001 From: Faisal Ahmed Date: Sat, 19 Feb 2022 15:31:11 +0600 Subject: [PATCH 2/2] remove .idea files --- .idea/.gitignore | 8 -------- .idea/event-loop.iml | 47 -------------------------------------------- .idea/modules.xml | 8 -------- .idea/php.xml | 43 ---------------------------------------- .idea/vcs.xml | 6 ------ 5 files changed, 112 deletions(-) delete mode 100644 .idea/.gitignore delete mode 100644 .idea/event-loop.iml delete mode 100644 .idea/modules.xml delete mode 100644 .idea/php.xml delete mode 100644 .idea/vcs.xml diff --git a/.idea/.gitignore b/.idea/.gitignore deleted file mode 100644 index 13566b81..00000000 --- a/.idea/.gitignore +++ /dev/null @@ -1,8 +0,0 @@ -# Default ignored files -/shelf/ -/workspace.xml -# Editor-based HTTP Client requests -/httpRequests/ -# Datasource local storage ignored files -/dataSources/ -/dataSources.local.xml diff --git a/.idea/event-loop.iml b/.idea/event-loop.iml deleted file mode 100644 index 0f3900f5..00000000 --- a/.idea/event-loop.iml +++ /dev/null @@ -1,47 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/.idea/modules.xml b/.idea/modules.xml deleted file mode 100644 index 9102eb9f..00000000 --- a/.idea/modules.xml +++ /dev/null @@ -1,8 +0,0 @@ - - - - - - - - \ No newline at end of file diff --git a/.idea/php.xml b/.idea/php.xml deleted file mode 100644 index aea11b31..00000000 --- a/.idea/php.xml +++ /dev/null @@ -1,43 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/.idea/vcs.xml b/.idea/vcs.xml deleted file mode 100644 index 94a25f7f..00000000 --- a/.idea/vcs.xml +++ /dev/null @@ -1,6 +0,0 @@ - - - - - - \ No newline at end of file