From 69495a0835ae1af1808cd0fc8c80d7409c96238f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kuba=20Wer=C5=82os?= Date: Fri, 22 Aug 2025 11:28:01 +0200 Subject: [PATCH 1/3] Add PHP 8.5 to CI --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e3c5ae8..fa30861 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,6 +14,7 @@ jobs: - ubuntu-24.04 - windows-2022 php: + - 8.5 - 8.4 - 8.3 - 8.2 From a6b551aa8c876fd0448d856632fa3809a4fc7520 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kuba=20Wer=C5=82os?= Date: Fri, 22 Aug 2025 11:29:29 +0200 Subject: [PATCH 2/3] Change `(binary)` to `(string)` --- src/Process.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Process.php b/src/Process.php index 406e417..86c334a 100644 --- a/src/Process.php +++ b/src/Process.php @@ -121,7 +121,7 @@ public function __construct($cmd, $cwd = null, $env = null, $fds = null) if (null !== $env) { $this->env = array(); foreach ($env as $key => $value) { - $this->env[(binary) $key] = (binary) $value; + $this->env[(string) $key] = (string) $value; } } From c27ac3ce434c9bc0e5779a98f243a5f5c2224555 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kuba=20Wer=C5=82os?= Date: Fri, 22 Aug 2025 11:30:44 +0200 Subject: [PATCH 3/3] Do not call `ReflectionProperty::setAccessible()` when not needed --- tests/AbstractProcessTest.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/AbstractProcessTest.php b/tests/AbstractProcessTest.php index 4a81d0b..8afe39b 100644 --- a/tests/AbstractProcessTest.php +++ b/tests/AbstractProcessTest.php @@ -70,7 +70,9 @@ public function testStartWithoutLoopAssignsLoopAutomatically() $process->start(); $ref = new \ReflectionProperty($process->stdin, 'loop'); - $ref->setAccessible(true); + if (PHP_VERSION_ID < 80100) { + $ref->setAccessible(true); + } $loop = $ref->getValue($process->stdin); $this->assertInstanceOf('React\EventLoop\LoopInterface', $loop);