Skip to content

Commit dbcf370

Browse files
committed
Merge branch 'main' of https://github.com/reactjs/reactjs.org into sync-49ebed1b
2 parents c44110d + 49ebed1 commit dbcf370

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/components/Layout/Feedback.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,15 @@ const thumbsDownIcon = (
4545
);
4646

4747
function sendGAEvent(isPositive: boolean) {
48+
const category = isPositive ? 'like_button' : 'dislike_button';
4849
const value = isPositive ? 1 : 0;
4950
// Fragile. Don't change unless you've tested the network payload
5051
// and verified that the right events actually show up in GA.
5152
// @ts-ignore
5253
gtag('event', 'feedback', {
53-
event_category: 'button',
54+
event_category: category,
5455
event_label: window.location.pathname,
55-
value,
56+
event_value: value,
5657
});
5758
}
5859

src/content/reference/react/useOptimistic.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ export default function App() {
116116
]);
117117
async function sendMessage(formData) {
118118
const sentMessage = await deliverMessage(formData.get("message"));
119-
setMessages([...messages, { text: sentMessage }]);
119+
setMessages((messages) => [...messages, { text: sentMessage }]);
120120
}
121121
return <Thread messages={messages} sendMessage={sendMessage} />;
122122
}

0 commit comments

Comments
 (0)