Skip to content

Dependency changes #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justin808 opened this issue Aug 15, 2022 · 4 comments · Fixed by #1218
Closed

Dependency changes #1195

justin808 opened this issue Aug 15, 2022 · 4 comments · Fixed by #1218

Comments

@justin808
Copy link
Collaborator

  1. Webpack needs to be updated.
  2. react_ujs should be removed as a dependency (circular)
  "devDependencies": {
    "webpack": "^2.3.3"
  },
  "dependencies": {
    "react_ujs": "^2.6.1"
  }
@alkesh26
Copy link
Collaborator

alkesh26 commented Oct 7, 2022

@justin808, We need to work on these changes.

@justin808 justin808 added this to the 2.7 milestone Nov 2, 2022
@justin808
Copy link
Collaborator Author

@ahangarha maybe this is already done? If not, please do.

@ahangarha
Copy link
Collaborator

As on now, react_ujs has been removed from dependencies.

Should webpack be updated to latest version? from 2.3.3 to 5.74.0?

@justin808
Copy link
Collaborator Author

Yes, 5.74.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants