Skip to content

find_builtin_server_type should return Optional server type #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rmorshea opened this issue Jun 12, 2021 · 1 comment
Closed

find_builtin_server_type should return Optional server type #394

rmorshea opened this issue Jun 12, 2021 · 1 comment

Comments

@rmorshea
Copy link
Collaborator

This should not raise an error: https://github.com/idom-team/idom/blob/8a99b452fd877bea78b9718c1e32e8855c768166/src/idom/server/prefab.py#L16

It should just return None if no server implementations are installed. An error should then be raised at runtime if no server is explicitly given and no default exists.
@rmorshea
Copy link
Collaborator Author

Fixed by: e29745e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmorshea