feat: Modal and Overlay transitions do not trigger findDOMnode warnings #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This PR has been opened for 5 months, and there has been no movement on this. We moved to react-restart from react-overlays because this implementation was supposedly being maintained, but I'm concerned that there are 5 open PRs that appear to be unreviewed. |
Collaborator
|
Sorry for the lack of response. I've been busy and this slipped my mind. On first glance this does look like a breaking change due to renaming of functions. I'll take a closer look later when I'm free |
Collaborator
|
Implemented non-breaking changes in #97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93.