From 044824d82680fcf8971fe0e000116790d3559902 Mon Sep 17 00:00:00 2001 From: LeoTM <1881059+leotm@users.noreply.github.com> Date: Wed, 29 Jun 2022 19:44:55 +0100 Subject: [PATCH 1/7] Add TODO --- template/tsconfig.json | 1 + 1 file changed, 1 insertion(+) diff --git a/template/tsconfig.json b/template/tsconfig.json index 77163506..a393636e 100644 --- a/template/tsconfig.json +++ b/template/tsconfig.json @@ -1,5 +1,6 @@ // prettier-ignore { + // TODO: Extend and doc "compilerOptions": { /* Visit https://aka.ms/tsconfig.json to read more about this file */ From 6fb3c1d5ed603f36350829d7abdb55df45511a9b Mon Sep 17 00:00:00 2001 From: LeoTM <1881059+leotm@users.noreply.github.com> Date: Wed, 29 Jun 2022 20:43:07 +0100 Subject: [PATCH 2/7] Add devdep @tsconfig/react-native v2 --- template/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/template/package.json b/template/package.json index 028daabc..0a853434 100644 --- a/template/package.json +++ b/template/package.json @@ -17,6 +17,7 @@ "@babel/core": "^7.12.9", "@babel/runtime": "^7.12.5", "@react-native-community/eslint-config": "^2.0.0", + "@tsconfig/react-native": "^2.0.0", "@types/jest": "^26.0.23", "@types/react-native": "^0.69.0", "@types/react-test-renderer": "^18.0.0", From 697421c1da598285c93b24bfa95cebaca3fe8e73 Mon Sep 17 00:00:00 2001 From: LeoTM <1881059+leotm@users.noreply.github.com> Date: Wed, 29 Jun 2022 20:45:24 +0100 Subject: [PATCH 3/7] Extend recommended React Native TSConfig base --- template/tsconfig.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template/tsconfig.json b/template/tsconfig.json index a393636e..2ade58bd 100644 --- a/template/tsconfig.json +++ b/template/tsconfig.json @@ -1,6 +1,6 @@ // prettier-ignore { - // TODO: Extend and doc + "extends": "@tsconfig/react-native/tsconfig.json", "compilerOptions": { /* Visit https://aka.ms/tsconfig.json to read more about this file */ From 205993112ab2420833d449fc97136348c3bc4fa5 Mon Sep 17 00:00:00 2001 From: LeoTM <1881059+leotm@users.noreply.github.com> Date: Wed, 29 Jun 2022 20:45:45 +0100 Subject: [PATCH 4/7] Doc recommended React Native TSConfig base --- template/tsconfig.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template/tsconfig.json b/template/tsconfig.json index 2ade58bd..ba913e2d 100644 --- a/template/tsconfig.json +++ b/template/tsconfig.json @@ -1,6 +1,6 @@ // prettier-ignore { - "extends": "@tsconfig/react-native/tsconfig.json", + "extends": "@tsconfig/react-native/tsconfig.json", /* Recommended React Native TSConfig base */ "compilerOptions": { /* Visit https://aka.ms/tsconfig.json to read more about this file */ From 153628a20bf64c6d959cdb0d6416a904cd02f3e6 Mon Sep 17 00:00:00 2001 From: LeoTM <1881059+leotm@users.noreply.github.com> Date: Thu, 30 Jun 2022 16:10:06 +0100 Subject: [PATCH 5/7] Remove tsc --init comments now that we're extending --- template/tsconfig.json | 92 +----------------------------------------- 1 file changed, 1 insertion(+), 91 deletions(-) diff --git a/template/tsconfig.json b/template/tsconfig.json index ba913e2d..ce38a1dc 100644 --- a/template/tsconfig.json +++ b/template/tsconfig.json @@ -4,103 +4,13 @@ "compilerOptions": { /* Visit https://aka.ms/tsconfig.json to read more about this file */ - /* Projects */ - // "incremental": true, /* Enable incremental compilation */ - // "composite": true, /* Enable constraints that allow a TypeScript project to be used with project references. */ - // "tsBuildInfoFile": "./", /* Specify the folder for .tsbuildinfo incremental compilation files. */ - // "disableSourceOfProjectReferenceRedirect": true, /* Disable preferring source files instead of declaration files when referencing composite projects */ - // "disableSolutionSearching": true, /* Opt a project out of multi-project reference checking when editing. */ - // "disableReferencedProjectLoad": true, /* Reduce the number of projects loaded automatically by TypeScript. */ - /* Language and Environment */ - "target": "esnext", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */ "lib": ["es2019"], /* Specify a set of bundled library declaration files that describe the target runtime environment. */ - "jsx": "react-native", /* Specify what JSX code is generated. */ - // "experimentalDecorators": true, /* Enable experimental support for TC39 stage 2 draft decorators. */ - // "emitDecoratorMetadata": true, /* Emit design-type metadata for decorated declarations in source files. */ - // "jsxFactory": "", /* Specify the JSX factory function used when targeting React JSX emit, e.g. 'React.createElement' or 'h' */ - // "jsxFragmentFactory": "", /* Specify the JSX Fragment reference used for fragments when targeting React JSX emit e.g. 'React.Fragment' or 'Fragment'. */ - // "jsxImportSource": "", /* Specify module specifier used to import the JSX factory functions when using `jsx: react-jsx*`.` */ - // "reactNamespace": "", /* Specify the object invoked for `createElement`. This only applies when targeting `react` JSX emit. */ - // "noLib": true, /* Disable including any library files, including the default lib.d.ts. */ - // "useDefineForClassFields": true, /* Emit ECMAScript-standard-compliant class fields. */ - - /* Modules */ - "module": "commonjs", /* Specify what module code is generated. */ - // "rootDir": "./", /* Specify the root folder within your source files. */ - "moduleResolution": "node", /* Specify how TypeScript looks up a file from a given module specifier. */ - // "baseUrl": "./", /* Specify the base directory to resolve non-relative module names. */ - // "paths": {}, /* Specify a set of entries that re-map imports to additional lookup locations. */ - // "rootDirs": [], /* Allow multiple folders to be treated as one when resolving modules. */ - // "typeRoots": [], /* Specify multiple folders that act like `./node_modules/@types`. */ - "types": ["react-native", "jest"], /* Specify type package names to be included without being referenced in a source file. */ - // "allowUmdGlobalAccess": true, /* Allow accessing UMD globals from modules. */ - "resolveJsonModule": true, /* Enable importing .json files */ - // "noResolve": true, /* Disallow `import`s, `require`s or ``s from expanding the number of files TypeScript should add to a project. */ - - /* JavaScript Support */ - "allowJs": true, /* Allow JavaScript files to be a part of your program. Use the `checkJS` option to get errors from these files. */ - // "checkJs": true, /* Enable error reporting in type-checked JavaScript files. */ - // "maxNodeModuleJsDepth": 1, /* Specify the maximum folder depth used for checking JavaScript files from `node_modules`. Only applicable with `allowJs`. */ - - /* Emit */ - // "declaration": true, /* Generate .d.ts files from TypeScript and JavaScript files in your project. */ - // "declarationMap": true, /* Create sourcemaps for d.ts files. */ - // "emitDeclarationOnly": true, /* Only output d.ts files and not JavaScript files. */ - // "sourceMap": true, /* Create source map files for emitted JavaScript files. */ - // "outFile": "./", /* Specify a file that bundles all outputs into one JavaScript file. If `declaration` is true, also designates a file that bundles all .d.ts output. */ - // "outDir": "./", /* Specify an output folder for all emitted files. */ - // "removeComments": true, /* Disable emitting comments. */ - "noEmit": true, /* Disable emitting files from a compilation. */ - // "importHelpers": true, /* Allow importing helper functions from tslib once per project, instead of including them per-file. */ - // "importsNotUsedAsValues": "remove", /* Specify emit/checking behavior for imports that are only used for types */ - // "downlevelIteration": true, /* Emit more compliant, but verbose and less performant JavaScript for iteration. */ - // "sourceRoot": "", /* Specify the root path for debuggers to find the reference source code. */ - // "mapRoot": "", /* Specify the location where debugger should locate map files instead of generated locations. */ - // "inlineSourceMap": true, /* Include sourcemap files inside the emitted JavaScript. */ - // "inlineSources": true, /* Include source code in the sourcemaps inside the emitted JavaScript. */ - // "emitBOM": true, /* Emit a UTF-8 Byte Order Mark (BOM) in the beginning of output files. */ - // "newLine": "crlf", /* Set the newline character for emitting files. */ - // "stripInternal": true, /* Disable emitting declarations that have `@internal` in their JSDoc comments. */ - // "noEmitHelpers": true, /* Disable generating custom helper functions like `__extends` in compiled output. */ - // "noEmitOnError": true, /* Disable emitting files if any type checking errors are reported. */ - // "preserveConstEnums": true, /* Disable erasing `const enum` declarations in generated code. */ - // "declarationDir": "./", /* Specify the output directory for generated declaration files. */ - // "preserveValueImports": true, /* Preserve unused imported values in the JavaScript output that would otherwise be removed. */ /* Interop Constraints */ - "isolatedModules": true, /* Ensure that each file can be safely transpiled without relying on other imports. */ - "allowSyntheticDefaultImports": true, /* Allow 'import x from y' when a module doesn't have a default export. */ - "esModuleInterop": true, /* Emit additional JavaScript to ease support for importing CommonJS modules. This enables `allowSyntheticDefaultImports` for type compatibility. */ - // "preserveSymlinks": true, /* Disable resolving symlinks to their realpath. This correlates to the same flag in node. */ "forceConsistentCasingInFileNames": true, /* Ensure that casing is correct in imports. */ - /* Type Checking */ - "strict": true, /* Enable all strict type-checking options. */ - // "noImplicitAny": true, /* Enable error reporting for expressions and declarations with an implied `any` type.. */ - // "strictNullChecks": true, /* When type checking, take into account `null` and `undefined`. */ - // "strictFunctionTypes": true, /* When assigning functions, check to ensure parameters and the return values are subtype-compatible. */ - // "strictBindCallApply": true, /* Check that the arguments for `bind`, `call`, and `apply` methods match the original function. */ - // "strictPropertyInitialization": true, /* Check for class properties that are declared but not set in the constructor. */ - // "noImplicitThis": true, /* Enable error reporting when `this` is given the type `any`. */ - // "useUnknownInCatchVariables": true, /* Type catch clause variables as 'unknown' instead of 'any'. */ - // "alwaysStrict": true, /* Ensure 'use strict' is always emitted. */ - // "noUnusedLocals": true, /* Enable error reporting when a local variables aren't read. */ - // "noUnusedParameters": true, /* Raise an error when a function parameter isn't read */ - // "exactOptionalPropertyTypes": true, /* Interpret optional property types as written, rather than adding 'undefined'. */ - // "noImplicitReturns": true, /* Enable error reporting for codepaths that do not explicitly return in a function. */ - // "noFallthroughCasesInSwitch": true, /* Enable error reporting for fallthrough cases in switch statements. */ - // "noUncheckedIndexedAccess": true, /* Include 'undefined' in index signature results */ - // "noImplicitOverride": true, /* Ensure overriding members in derived classes are marked with an override modifier. */ - // "noPropertyAccessFromIndexSignature": true, /* Enforces using indexed accessors for keys declared using an indexed type */ - // "allowUnusedLabels": true, /* Disable error reporting for unused labels. */ - // "allowUnreachableCode": true, /* Disable error reporting for unreachable code. */ - /* Completeness */ - // "skipDefaultLibCheck": true, /* Skip type checking .d.ts files that are included with TypeScript. */ "skipLibCheck": true /* Skip type checking all .d.ts files. */ - }, - "exclude": [ - "node_modules", "babel.config.js", "metro.config.js", "jest.config.js" - ] + } } From 053f5fe0ba2bda5df9130ce39d4bcff0f40e21f2 Mon Sep 17 00:00:00 2001 From: LeoTM <1881059+leotm@users.noreply.github.com> Date: Thu, 30 Jun 2022 20:35:31 +0100 Subject: [PATCH 6/7] Remove es2019 lib override - merged in https://github.com/tsconfig/bases/pull/116 - now in https://github.com/tsconfig/bases/blob/main/bases/react-native.json - no longer needed since extended --- template/tsconfig.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/template/tsconfig.json b/template/tsconfig.json index ce38a1dc..365ea8cf 100644 --- a/template/tsconfig.json +++ b/template/tsconfig.json @@ -4,9 +4,6 @@ "compilerOptions": { /* Visit https://aka.ms/tsconfig.json to read more about this file */ - /* Language and Environment */ - "lib": ["es2019"], /* Specify a set of bundled library declaration files that describe the target runtime environment. */ - /* Interop Constraints */ "forceConsistentCasingInFileNames": true, /* Ensure that casing is correct in imports. */ From 4508dc06eaabad6d602cd2d0db1dec85a9cf68a1 Mon Sep 17 00:00:00 2001 From: LeoTM <1881059+leotm@users.noreply.github.com> Date: Thu, 30 Jun 2022 20:37:41 +0100 Subject: [PATCH 7/7] Remove forceConsistentCasingInFileNames override - merged in https://github.com/tsconfig/bases/pull/118 - now in https://github.com/tsconfig/bases/blob/main/bases/react-native.json - no longer needed since extended --- template/tsconfig.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/template/tsconfig.json b/template/tsconfig.json index 365ea8cf..0cc9cdd6 100644 --- a/template/tsconfig.json +++ b/template/tsconfig.json @@ -4,9 +4,6 @@ "compilerOptions": { /* Visit https://aka.ms/tsconfig.json to read more about this file */ - /* Interop Constraints */ - "forceConsistentCasingInFileNames": true, /* Ensure that casing is correct in imports. */ - /* Completeness */ "skipLibCheck": true /* Skip type checking all .d.ts files. */ }