Minor requested changes

* Use const and RCT prefix for RCTOldStorageDirectory
* Log errors instead of throwing exceptions
* Disable main queue setup

Author: reilem

ios/RNCAsyncStorage.m

@@ -163,15 +163,12 @@ static dispatch_queue_t RCTGetMethodQueue()
 }
 
 
-NSString *OldStorageDirectory = @"RNCAsyncLocalStorage_V1";
+NSString *const RCTOldStorageDirectory = @"RNCAsyncLocalStorage_V1";
 /**
  * Creates an NSException used during Storage Directory Migration.
  */
-static NSException *RCTStorageDirectionMigrationException(NSString *reason, NSError *error) {
-  NSMutableString *reasonString = [[NSMutableString alloc] initWithString:reason];
-  [reasonString appendString:@" - "];
-  [reasonString appendString:[error description]];
-  return [[NSException alloc] initWithName:@"RCTStorageDirectoryMigrationFailure" reason:reasonString userInfo:nil];
+static void RCTStorageDirectoryMigrationLogError(NSString *reason, NSError *error) {
+  NSLog(@"%@: %@", reason, error ? error.description : @"");
 }
 
 /**
@@ -184,24 +181,24 @@ static void RCTStorageDirectoryMigrationCheck() {
     NSError *error;
     BOOL isDir;
     // If the old directory exists, it means we need to migrate data to the new directory
-    if ([[NSFileManager defaultManager] fileExistsAtPath:RCTCreateStorageDirectoryPath(OldStorageDirectory) isDirectory:&isDir] && isDir) {
+    if ([[NSFileManager defaultManager] fileExistsAtPath:RCTCreateStorageDirectoryPath(RCTOldStorageDirectory) isDirectory:&isDir] && isDir) {
       // Check if the new storage directory location already exists
       BOOL newStorageDirectoryExists = [[NSFileManager defaultManager] fileExistsAtPath:RCTGetStorageDirectory() isDirectory:&isDir];
       if (newStorageDirectoryExists) {
         // If the new storage directory location already exists, remove existing directory
         newStorageDirectoryExists = !([[NSFileManager defaultManager] removeItemAtPath:RCTGetStorageDirectory() error:&error]);
         if (newStorageDirectoryExists) {
-          @throw RCTStorageDirectionMigrationException(@"Failed to clear pre-existing storage directory", error);
+          RCTStorageDirectoryMigrationLogError(@"Failed to clear pre-existing storage directory", error);
         }
       }
       if (!newStorageDirectoryExists) {
         // If new storage direction doesn't exist, copy old storage directory to new location
-        if (![[NSFileManager defaultManager] copyItemAtPath:RCTCreateStorageDirectoryPath(OldStorageDirectory) toPath:RCTGetStorageDirectory() error:&error]) {
-          @throw RCTStorageDirectionMigrationException(@"Failed to copy old storage directory to new storage directory", error);
+        if (![[NSFileManager defaultManager] copyItemAtPath:RCTCreateStorageDirectoryPath(RCTOldStorageDirectory) toPath:RCTGetStorageDirectory() error:&error]) {
+          RCTStorageDirectoryMigrationLogError(@"Failed to copy old storage directory to new storage directory", error);
         } else {
           // If copying succeeds, remove old storage directory
-          [[NSFileManager defaultManager] removeItemAtPath:RCTCreateStorageDirectoryPath(OldStorageDirectory) error:&error];
-          if (error) @throw RCTStorageDirectionMigrationException(@"Failed to remove old storage directory after migration", error);
+          [[NSFileManager defaultManager] removeItemAtPath:RCTCreateStorageDirectoryPath(RCTOldStorageDirectory) error:&error];
+          if (error) RCTStorageDirectoryMigrationLogError(@"Failed to remove old storage directory after migration", error);
         }
       }
     }
@@ -220,7 +217,7 @@ @implementation RNCAsyncStorage
 }
 
 + (BOOL)requiresMainQueueSetup {
-  return YES;
+  return NO;
 }
 
 - (instancetype)init
@@ -436,7 +433,7 @@ - (NSDictionary *)_writeEntry:(NSArray<NSString *> *)entry changedManifest:(BOOL
 }
 
 RCT_EXPORT_METHOD(multiMerge:(NSArray<NSArray<NSString *> *> *)kvPairs
-                    callback:(RCTResponseSenderBlock)callback)
+                  callback:(RCTResponseSenderBlock)callback)
 {
   NSDictionary *errorOut = [self _ensureSetup];
   if (errorOut) {
@@ -521,3 +518,4 @@ - (NSDictionary *)_writeEntry:(NSArray<NSString *> *)entry changedManifest:(BOOL
 }
 
 @end
+