From d7b725f2784641058f3aa73caaf298abc329f9e1 Mon Sep 17 00:00:00 2001 From: Andrew Scheller Date: Wed, 21 May 2025 08:10:45 +0100 Subject: [PATCH] Look for other possible "missing PICO_CONFIG" lines, and make message more obvious --- tools/extract_configs.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/extract_configs.py b/tools/extract_configs.py index 00ff3437b..0249d7349 100755 --- a/tools/extract_configs.py +++ b/tools/extract_configs.py @@ -231,8 +231,9 @@ def ValidateAttrs(config_name, config_attrs, file_path, linenum): chips_resolved_defines = defaultdict(dict) for applicable, all_defines in chips_all_defines.items(): for d in all_defines: - if d not in all_config_names and d.startswith("PICO_"): - logger.warning("Potential unmarked PICO define {}".format(d)) + for define_prefix in ('PICO', 'PARAM', 'CYW43'): + if d not in all_config_names and d.startswith(define_prefix+'_'): + logger.warning("#define {} is potentially missing a {}: entry".format(d, BASE_CONFIG_NAME)) resolved_defines = chips_resolved_defines[applicable] # resolve "nested defines" - this allows e.g. USB_DPRAM_MAX to resolve to USB_DPRAM_SIZE which is set to 4096 (which then matches the relevant PICO_CONFIG entry) for val in all_defines[d]: