Skip to content

Make boot_stage2 choice a function of the board header by default + make generic flash the default #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kilograham opened this issue Mar 21, 2021 · 2 comments · Fixed by #293
Closed

Make boot_stage2 choice a function of the board header by default + make generic flash the default #275

kilograham opened this issue Mar 21, 2021 · 2 comments · Fixed by #293
Assignees
@kilograham
Milestone
1.1.1

Comments

@kilograham
Copy link
Contributor

The "default bootstage2" mechanism should include a meta file which (effectively) includes the other bootstage 2's with #ifdef, thus allowing the board header to choose a bootstage2 without having to move to move up to using the cmake level board config.

The default if unspecified should be for generic slow flash, so ppl don't get bitten by non working flash.
@kilograham kilograham self-assigned this Mar 21, 2021
@kilograham kilograham added this to the 1.2.0 milestone Mar 21, 2021
@lurch lurch mentioned this issue Mar 24, 2021
Closed
@kilograham kilograham modified the milestones: 1.2.0, 1.1.1 Mar 24, 2021
@kilograham
Copy link
Contributor Author

moving to 1.1.1 as it blocks simple fixes for some boards

@aallan aallan mentioned this issue Mar 31, 2021
Closed
@kilograham kilograham mentioned this issue Mar 31, 2021
Merged
@kilograham kilograham linked a pull request Mar 31, 2021 that will close this issue
build: allow board config header to specify bootstage 2 without using custom per board cmake #293
Merged
@kilograham
Copy link
Contributor Author

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kilograham kilograham

Labels
None yet
Projects
None yet
Milestone
1.1.1
1 participant
@kilograham