From 6c3dd22c9245ed0154da710049afb0e1e671dcb6 Mon Sep 17 00:00:00 2001 From: Tiago Freire <41837236+tiagofreire-pt@users.noreply.github.com> Date: Tue, 23 Jan 2024 09:46:18 +0000 Subject: [PATCH 1/5] Improvement on backup-switchover-mode overlay value definitions For the RV3028 RTC, the definitions for its `backup-switchover-mode` overlay were not intelligible neither complete/exhaustive. Accordingly to the https://github.com/raspberrypi/linux/issues/2912#issuecomment-477670051, these one here proposed should be correct. `/boot/config.txt` should be as a configuration example, for rv3028, on a Uputronics GPS Extension HAT: ``` # For GPS Expansion Board from Uputronics dtparam=i2c_arm=on dtoverlay=i2c-rtc,rv3028,backup-switchover-mode=3 dtoverlay=pps-gpio,gpiopin=18 init_uart_baud=115200 ``` From my tests (`sudo rmmod rtc_rv3028 && sudo i2cget -y 1 0x52 0x37`): `Default from factory`: `0x10` `Mode 0`: `0x10` `Mode 1`: `0x14` `Mode 2`: `0x18` `Mode 3`: `0x1c` `Mode 3`: `0x1c` is consistent with the manufacturer configuration script: http://store.uputronics.com/files/configure-rv3028.sh --- arch/arm/boot/dts/overlays/README | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/overlays/README b/arch/arm/boot/dts/overlays/README index ec66b1a6183b65..e68210b7058697 100644 --- a/arch/arm/boot/dts/overlays/README +++ b/arch/arm/boot/dts/overlays/README @@ -2106,7 +2106,13 @@ Params: abx80x Select one of the ABx80x family: source backup-switchover-mode Backup power supply switch mode. Must be 0 for - off or 1 for Vdd < VBackup (RV3028, RV3032) + "Switchover disabled", 1 for "Direct Switching" + (switchover when Vdd < VBackup), 2 for "Standby + Mode" (go into standby when Vdd < Vbackup, + does not draw current) or 3 (recommended) for + "Level Switching" (switchover when Vdd < Vbackup + and Vdd < Vddsw and Vbackup > Vddsw) + (RV3028, RV3032) Name: i2c-rtc-gpio From 9075e46852f124f5952ef22a25e0bcc548857b41 Mon Sep 17 00:00:00 2001 From: Tiago Freire <41837236+tiagofreire-pt@users.noreply.github.com> Date: Tue, 23 Jan 2024 09:56:56 +0000 Subject: [PATCH 2/5] Trailing spaces removal --- arch/arm/boot/dts/overlays/README | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/overlays/README b/arch/arm/boot/dts/overlays/README index e68210b7058697..3f84ccd2deb715 100644 --- a/arch/arm/boot/dts/overlays/README +++ b/arch/arm/boot/dts/overlays/README @@ -2108,9 +2108,9 @@ Params: abx80x Select one of the ABx80x family: backup-switchover-mode Backup power supply switch mode. Must be 0 for "Switchover disabled", 1 for "Direct Switching" (switchover when Vdd < VBackup), 2 for "Standby - Mode" (go into standby when Vdd < Vbackup, - does not draw current) or 3 (recommended) for - "Level Switching" (switchover when Vdd < Vbackup + Mode" (go into standby when Vdd < Vbackup, + does not draw current) or 3 (recommended) for + "Level Switching" (switchover when Vdd < Vbackup and Vdd < Vddsw and Vbackup > Vddsw) (RV3028, RV3032) From 79b78521b4ebb5f9ff615da70f90e6ec2a589f79 Mon Sep 17 00:00:00 2001 From: Tiago Freire <41837236+tiagofreire-pt@users.noreply.github.com> Date: Tue, 23 Jan 2024 10:01:15 +0000 Subject: [PATCH 3/5] Trailing space removal #2 --- arch/arm/boot/dts/overlays/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/overlays/README b/arch/arm/boot/dts/overlays/README index 3f84ccd2deb715..d461499efbf5f7 100644 --- a/arch/arm/boot/dts/overlays/README +++ b/arch/arm/boot/dts/overlays/README @@ -2106,7 +2106,7 @@ Params: abx80x Select one of the ABx80x family: source backup-switchover-mode Backup power supply switch mode. Must be 0 for - "Switchover disabled", 1 for "Direct Switching" + "Switchover disabled", 1 for "Direct Switching" (switchover when Vdd < VBackup), 2 for "Standby Mode" (go into standby when Vdd < Vbackup, does not draw current) or 3 (recommended) for From a4f11ddb7602a099d73bcc39fd9d95cd03d44c2c Mon Sep 17 00:00:00 2001 From: Tiago Freire <41837236+tiagofreire-pt@users.noreply.github.com> Date: Tue, 23 Jan 2024 10:43:52 +0000 Subject: [PATCH 4/5] Shortening the definitions Signed-off-by: Tiago Freire --- arch/arm/boot/dts/overlays/README | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/overlays/README b/arch/arm/boot/dts/overlays/README index d461499efbf5f7..4f62ef003e9033 100644 --- a/arch/arm/boot/dts/overlays/README +++ b/arch/arm/boot/dts/overlays/README @@ -2107,10 +2107,10 @@ Params: abx80x Select one of the ABx80x family: backup-switchover-mode Backup power supply switch mode. Must be 0 for "Switchover disabled", 1 for "Direct Switching" - (switchover when Vdd < VBackup), 2 for "Standby - Mode" (go into standby when Vdd < Vbackup, - does not draw current) or 3 (recommended) for - "Level Switching" (switchover when Vdd < Vbackup + (switchover if Vdd < VBackup), 2 for "Standby + Mode" (standby if Vdd < Vbackup, + does not draw current) or 3 for + "Level Switching" (switchover if Vdd < Vbackup and Vdd < Vddsw and Vbackup > Vddsw) (RV3028, RV3032) From 11d2ddf98521e6c26eb83c41b40375314fb34423 Mon Sep 17 00:00:00 2001 From: Tiago Freire <41837236+tiagofreire-pt@users.noreply.github.com> Date: Tue, 23 Jan 2024 10:51:17 +0000 Subject: [PATCH 5/5] Shortening definitions even further Signed-off-by: Tiago Freire <41837236+tiagofreire-pt@users.noreply.github.com> --- arch/arm/boot/dts/overlays/README | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/overlays/README b/arch/arm/boot/dts/overlays/README index 4f62ef003e9033..62b356b199ccbf 100644 --- a/arch/arm/boot/dts/overlays/README +++ b/arch/arm/boot/dts/overlays/README @@ -2107,10 +2107,10 @@ Params: abx80x Select one of the ABx80x family: backup-switchover-mode Backup power supply switch mode. Must be 0 for "Switchover disabled", 1 for "Direct Switching" - (switchover if Vdd < VBackup), 2 for "Standby - Mode" (standby if Vdd < Vbackup, + (if Vdd < VBackup), 2 for "Standby + Mode" (if Vdd < Vbackup, does not draw current) or 3 for - "Level Switching" (switchover if Vdd < Vbackup + "Level Switching" (if Vdd < Vbackup and Vdd < Vddsw and Vbackup > Vddsw) (RV3028, RV3032)