Skip to content

vc4_dpi fixes #4889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2022
Merged

vc4_dpi fixes #4889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90a8879
drm/vc4: For DPI, MEDIA_BUS_FMT_RGB565_1X16 is mode 1, not 3.
6by9 Feb 14, 2022
cd762b4
dtoverlays: Add additional mappings to vc4-kms-dpi-generic
6by9 Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions arch/arm/boot/dts/overlays/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3651,8 +3651,12 @@ Params: clock-frequency Display clock frequency (Hz)
rgb565 Change to RGB565 output on GPIOs 0-19
rgb565-padhi Change to RGB565 output on GPIOs 0-8, 12-17, and
20-24
bgr666 Change to BGR666 output on GPIOs 0-21.
bgr666-padhi Change to BGR666 output on GPIOs 0-9, 12-17, and
20-25
rgb666-padhi Change to RGB666 output on GPIOs 0-9, 12-17, and
20-25
bgr888 Change to BGR888 output on GPIOs 0-27
rgb888 Change to RGB888 output on GPIOs 0-27
bus-format Override the bus format for a MEDIA_BUS_FMT_*
value. NB also overridden by rgbXXX overrides.
Expand Down
5 changes: 5 additions & 0 deletions arch/arm/boot/dts/overlays/vc4-kms-dpi-generic-overlay.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,13 @@
<&dpi_node_generic>, "pinctrl-0:0=",<&dpi_16bit_gpio0>;
rgb565-padhi = <&panel_generic>, "bus-format:0=0x1020",
<&dpi_node_generic>, "pinctrl-0:0=",<&dpi_16bit_cpadhi_gpio0>;
bgr666 = <&panel_generic>, "bus-format:0=0x101f";
bgr666-padhi = <&panel_generic>, "bus-format:0=0x101e",
<&dpi_node_generic>, "pinctrl-0:0=",<&dpi_18bit_cpadhi_gpio0>;
rgb666-padhi = <&panel_generic>, "bus-format:0=0x1015",
<&dpi_node_generic>, "pinctrl-0:0=",<&dpi_18bit_cpadhi_gpio0>;
bgr888 = <&panel_generic>, "bus-format:0=0x1013",
<&dpi_node_generic>, "pinctrl-0:0=",<&dpi_gpio0>;
rgb888 = <&panel_generic>, "bus-format:0=0x100a",
<&dpi_node_generic>, "pinctrl-0:0=",<&dpi_gpio0>;
bus-format = <&panel_generic>, "bus-format:0";
Expand Down
2 changes: 1 addition & 1 deletion drivers/gpu/drm/vc4/vc4_dpi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder)
DPI_ORDER);
break;
case MEDIA_BUS_FMT_RGB565_1X16:
dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3,
dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_1,
DPI_FORMAT);
break;
case MEDIA_BUS_FMT_RGB565_1X24_CPADHI:
Expand Down