Skip to content

Commit 65b258d

Browse files
tombadavidplowman
authored andcommitted
HACK: libcamera: Camera public destructor
pybind11 needs a public destructor for Camera to be able to manage the shared_ptr. It's not clear why this is needed, and can it be fixed in pybind11. Looks like there's a suggested fix, which has not been merged: pybind/pybind11#2067 Signed-off-by: Tomi Valkeinen <[email protected]>
1 parent 8f729c8 commit 65b258d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/libcamera/camera.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,12 +114,12 @@ class Camera final : public Object, public std::enable_shared_from_this<Camera>,
114114
int start(const ControlList *controls = nullptr);
115115
int stop();
116116

117+
~Camera();
117118
private:
118119
LIBCAMERA_DISABLE_COPY(Camera)
119120

120121
Camera(std::unique_ptr<Private> d, const std::string &id,
121122
const std::set<Stream *> &streams);
122-
~Camera();
123123

124124
friend class PipelineHandler;
125125
void disconnect();

0 commit comments

Comments
 (0)