Skip to content

Commit cd426fe

Browse files
author
Ran Isenberg
committed
cr fixes
1 parent ac5554f commit cd426fe

File tree

5 files changed

+67
-49
lines changed

5 files changed

+67
-49
lines changed

aws_lambda_powertools/utilities/parameters/appconfig.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,14 @@
44

55

66
import os
7-
from typing import Any, Dict, Optional, Union
7+
from typing import TYPE_CHECKING, Any, Dict, Optional, Union
88
from uuid import uuid4
99

1010
import boto3
1111
from botocore.config import Config
12-
from mypy_boto3_appconfig import AppConfigClient
12+
13+
if TYPE_CHECKING:
14+
from mypy_boto3_appconfig import AppConfigClient
1315

1416
from ...shared import constants
1517
from ...shared.functions import resolve_env_var_choice
@@ -71,7 +73,7 @@ def __init__(
7173
application: Optional[str] = None,
7274
config: Optional[Config] = None,
7375
boto3_session: Optional[boto3.session.Session] = None,
74-
boto3_client: Optional[AppConfigClient] = None,
76+
boto3_client: Optional["AppConfigClient"] = None,
7577
):
7678
"""
7779
Initialize the App Config client

aws_lambda_powertools/utilities/parameters/secrets.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,13 @@
33
"""
44

55

6-
from typing import Any, Dict, Optional, Union
6+
from typing import TYPE_CHECKING, Any, Dict, Optional, Union
77

88
import boto3
99
from botocore.config import Config
10-
from mypy_boto3_secretsmanager import SecretsManagerClient
10+
11+
if TYPE_CHECKING:
12+
from mypy_boto3_secretsmanager import SecretsManagerClient
1113

1214
from .base import DEFAULT_MAX_AGE_SECS, DEFAULT_PROVIDERS, BaseProvider
1315

@@ -67,7 +69,7 @@ def __init__(
6769
self,
6870
config: Optional[Config] = None,
6971
boto3_session: Optional[boto3.session.Session] = None,
70-
boto3_client: Optional[SecretsManagerClient] = None,
72+
boto3_client: Optional["SecretsManagerClient"] = None,
7173
):
7274
"""
7375
Initialize the Secrets Manager client

aws_lambda_powertools/utilities/parameters/ssm.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,16 @@
33
"""
44

55

6-
from typing import Any, Dict, Optional, Union
6+
from typing import TYPE_CHECKING, Any, Dict, Optional, Union
77

88
import boto3
99
from botocore.config import Config
10-
from mypy_boto3_ssm import SSMClient
1110

1211
from .base import DEFAULT_MAX_AGE_SECS, DEFAULT_PROVIDERS, BaseProvider
1312

13+
if TYPE_CHECKING:
14+
from mypy_boto3_ssm import SSMClient
15+
1416

1517
class SSMProvider(BaseProvider):
1618
"""
@@ -83,7 +85,7 @@ def __init__(
8385
self,
8486
config: Optional[Config] = None,
8587
boto3_session: Optional[boto3.session.Session] = None,
86-
boto3_client: Optional[SSMClient] = None,
88+
boto3_client: Optional["SSMClient"] = None,
8789
):
8890
"""
8991
Initialize the SSM Parameter Store client

poetry.lock

Lines changed: 49 additions & 39 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ boto3 = "^1.18"
2727
jmespath = "^0.10.0"
2828
pydantic = {version = "^1.8.2", optional = true }
2929
email-validator = {version = "*", optional = true }
30-
boto3-stubs = {extras = ["appconfig", "ssm", "secretsmanager"], version = "^1.21.37"}
3130

3231
[tool.poetry.dev-dependencies]
3332
coverage = {extras = ["toml"], version = "^6.2"}
@@ -55,6 +54,9 @@ mkdocs-git-revision-date-plugin = "^0.3.1"
5554
mike = "^0.6.0"
5655
mypy = "^0.931"
5756
mkdocs-material = "^8.2.4"
57+
mypy-boto3-appconfig = "^1.21.34"
58+
mypy-boto3-ssm = "^1.21.34"
59+
mypy-boto3-secretsmanager = "^1.21.34"
5860

5961

6062
[tool.poetry.extras]

0 commit comments

Comments
 (0)