Skip to content

Test suite si broken since Spring 2.1.0 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
voxik opened this issue Oct 1, 2020 · 0 comments
Closed

Test suite si broken since Spring 2.1.0 #24

voxik opened this issue Oct 1, 2020 · 0 comments

Comments

@voxik
Copy link
Contributor

voxik commented Oct 1, 2020

The Spring 2.1.0 moved its testing bits out of lib into test directory [1], which breaks the test suite.

I was able to convince the test suite to run by having the Spring test suite at hand and these two simple changes:

sed -i '/spring\/test/ s/spring/support/' test/helper.rb
sed -i '/spring\/test/ s/^/#/' test/unit_test.rb

However, there remain one failure:

  1) Error:
ListenWatcherTest#test_add_directory_with_dangling_symlink:
NoMethodError: undefined method `check_stale' for #<Spring::Watcher::Listen:0x00007f355c0585a0>
    /builddir/build/BUILD/test/support/watcher_test.rb:189:in `block in <class:WatcherTest>'

It seems that the polling adapter support #check_stale method, which is, however, not part of the abstract interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant