Fixed Ruff linter defaulting to python3.8 #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafsaf
approved these changes
Nov 8, 2023
Owner
rafsaf
left a comment
rafsaf
left a comment
There was a problem hiding this comment.
Wow, I wasn't aware that ruff is using py3.8 by default. I think I noticed this weird order change of "import tomllib", but I moved to doing something else and forgot about it.
Thanks a lot :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff currently defaults to linting code as if it was Python 3.8, hence the tomllib import being moved in commit 7edb31c.
It can be specified with
requires-python = ">= 3.12"in the[project]section of pyproject.toml, but since you are not using that section I used the Ruff specific option.