Fix rabbitmq-diagnostics remote_shell for 26.0 #7441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essen
force-pushed
the
lh-fix-remote_shell-26
branch
from
e026aed to
b483202
Compare
mergify bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
(cherry picked from commit 74ce1a4)
mkuratczyk
pushed a commit
that referenced
this pull request
Feb 27, 2023
(cherry picked from commit 74ce1a4) Co-authored-by: Loïc Hoguin <[email protected]>
Contributor
|
@Mergifyio backport v3.11.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
(cherry picked from commit 74ce1a4)
michaelklishin
added a commit
that referenced
this pull request
Feb 28, 2023
Fix rabbitmq-diagnostics remote_shell for 26.0 (backport #7441)
mergify bot
added a commit
that referenced
this pull request
May 12, 2023
(cherry picked from commit 74ce1a4) Co-authored-by: Loïc Hoguin <[email protected]> (cherry picked from commit c83f3e1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed the format commands because I have no idea why they make compilation fail with my changes and I don't know how to fix (no clear error message). If the format commands are important please someone who knows fix the PR or provide instructions.
This PR fixes remote_shell for 26.0 and future versions and simplifies the code by using the new function from 26 (or will once the <26 compat gets removed).
cc @mkuratczyk