Skip to content

Conversation

@kjnilsson
Copy link
Contributor

@kjnilsson kjnilsson commented Feb 5, 2019

Also contains various fixes for Ra logging.

[#163724857]

Requires rabbitmq/ra#53

And rabbitmq/rabbitmq-common#297

Copy link
Collaborator

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A dependent change requires a gmake clean in the Umbrella.

Log entries with this change look like this:

2019-02-05 16:46:21.091 [notice] <0.672.0> queue 'qq.2' in vhost '/': candidate -> leader in term: 1
2019-02-05 16:46:21.091 [info] <0.668.0> ra: started cluster %2F_qq.2 with 1 servers
0 servers failed to start: []
Leader: {'%2F_qq.2',rabbit@warp10}
2019-02-05 16:46:21.110 [debug] <0.672.0> queue 'qq.2' in vhost '/': enabling ra cluster changes in 1
2019-02-05 16:46:42.918 [info] <0.672.0> queue 'qq.2' in vhost '/': terminating with {shutdown,delete} in state leader

So Ra logs its node IDs but quorum queues use more specific names such as queue 'qq.2' in vhost '/'.

@michaelklishin michaelklishin merged commit 4707e09 into master Feb 5, 2019
@michaelklishin michaelklishin deleted the qq-log-formatting branch February 5, 2019 13:49
michaelklishin added a commit that referenced this pull request Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants