Skip to content

Conversation

@essen
Copy link
Contributor

@essen essen commented Oct 23, 2018

This set of PRs is ready. Full set listed in rabbitmq/rabbitmq-common#279

Proposed Changes

Please describe the big picture of your changes here to communicate to the
RabbitMQ team why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure to link to that issue.

A pull request that doesn't explain why the change was made has a much
lower chance of being accepted.

If English isn't your first language, don't worry about it and try to
communicate the problem you are trying to solve to the best of your abilities.
As long as we can understand the intent, it's all good.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@essen
Copy link
Contributor Author

essen commented Nov 20, 2018

Depends on rabbitmq/rabbitmq-common#282 + a few tiny changes.

@essen essen force-pushed the ranch_proxy_header branch from df8772c to 0962eee Compare December 4, 2018 12:12
@essen essen changed the title WIP: Use the built-in Ranch PROXY protocol support Use the built-in Ranch PROXY protocol support Dec 4, 2018
@michaelklishin michaelklishin merged commit dbe1dea into master Dec 5, 2018
@michaelklishin michaelklishin deleted the ranch_proxy_header branch December 5, 2018 17:49
@acogoluegnes
Copy link
Contributor

acogoluegnes commented Dec 7, 2018

@michaelklishin
Copy link
Collaborator

This and related PRs have been backported to v3.7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants