Skip to content

Conversation

@lukebakken
Copy link
Collaborator

@lukebakken lukebakken commented Apr 19, 2018

This will take into account error conditions which will default to the value returned by inet:gethostname/0

See this rabbitmq-users thread

rabbit_net:hostname/0

This will take into account error conditions which will default to the value returned by inet:gethostname()
@lukebakken lukebakken added this to the 3.8.0 milestone Apr 19, 2018
@michaelklishin
Copy link
Collaborator

Thank you. rabbit_net:hostname/0 has to be exported for this to work, I'll take care of that.

michaelklishin added a commit to rabbitmq/rabbitmq-common that referenced this pull request Apr 20, 2018
@michaelklishin
Copy link
Collaborator

FTR, the rabbit-common commit to go with this is rabbitmq/rabbitmq-common@83ba37e.

@michaelklishin michaelklishin merged commit a6a546f into master Apr 20, 2018
@michaelklishin michaelklishin deleted the lrb-more-forgiving-hostname-lookup branch April 20, 2018 17:32
michaelklishin added a commit to rabbitmq/rabbitmq-common that referenced this pull request Apr 20, 2018
References rabbitmq/rabbitmq-server#1580.

(cherry picked from commit 83ba37e)
HoloRin pushed a commit to rabbitmq/rabbitmq-monorepo that referenced this pull request Aug 11, 2020
References rabbitmq/rabbitmq-server#1580.

(cherry picked from commit 552af3f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants