Skip to content

Commit 8d220b1

Browse files
committed
rabbit_stream_SUITE: Remove the sac_ff testcase
This testcase is irrelevant now that the `stream_single_active_consumer` feature flag is required.
1 parent c57d8cb commit 8d220b1

File tree

1 file changed

+1
-44
lines changed

1 file changed

+1
-44
lines changed

deps/rabbitmq_stream/test/rabbit_stream_SUITE.erl

Lines changed: 1 addition & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ all() ->
3333

3434
groups() ->
3535
[{single_node, [],
36-
[sac_ff, %% must stay at the top, stream sac feature flag disabled for this one
37-
test_stream,
36+
[test_stream,
3837
test_stream_tls,
3938
test_gc_consumers,
4039
test_gc_publishers,
@@ -133,13 +132,6 @@ end_per_group(_, Config) ->
133132
init_per_testcase(_TestCase, Config) ->
134133
Config.
135134

136-
end_per_testcase(sac_ff, Config) ->
137-
rabbit_ct_broker_helpers:rpc(Config,
138-
0,
139-
rabbit_feature_flags,
140-
enable,
141-
[stream_single_active_consumer]),
142-
ok;
143135
end_per_testcase(_Test, _Config) ->
144136
ok.
145137

@@ -290,41 +282,6 @@ timeout_close_sent(Config) ->
290282
% Now, rabbit_stream_reader is in state close_sent.
291283
?assertEqual(closed, wait_for_socket_close(gen_tcp, S, 1)).
292284

293-
sac_ff(Config) ->
294-
Port = get_stream_port(Config),
295-
{ok, S} =
296-
gen_tcp:connect("localhost", Port, [{active, false}, {mode, binary}]),
297-
C = rabbit_stream_core:init(0),
298-
test_peer_properties(gen_tcp, S, C),
299-
test_authenticate(gen_tcp, S, C),
300-
Stream = atom_to_binary(?FUNCTION_NAME, utf8),
301-
test_create_stream(gen_tcp, S, Stream, C),
302-
test_declare_publisher(gen_tcp, S, 1, Stream, C),
303-
?awaitMatch(#{publishers := 1}, get_global_counters(Config), ?WAIT),
304-
Body = <<"hello">>,
305-
test_publish_confirm(gen_tcp, S, 1, Body, C),
306-
307-
SubscriptionId = 42,
308-
SubCmd =
309-
{request, 1,
310-
{subscribe,
311-
SubscriptionId,
312-
Stream,
313-
0,
314-
10,
315-
#{<<"single-active-consumer">> => <<"true">>,
316-
<<"name">> => <<"foo">>}}},
317-
SubscribeFrame = rabbit_stream_core:frame(SubCmd),
318-
ok = gen_tcp:send(S, SubscribeFrame),
319-
{Cmd, C} = receive_commands(gen_tcp, S, C),
320-
?assertMatch({response, 1,
321-
{subscribe, ?RESPONSE_CODE_PRECONDITION_FAILED}},
322-
Cmd),
323-
test_delete_stream(gen_tcp, S, Stream, C),
324-
test_close(gen_tcp, S, C),
325-
closed = wait_for_socket_close(gen_tcp, S, 10),
326-
ok.
327-
328285
max_segment_size_bytes_validation(Config) ->
329286
Transport = gen_tcp,
330287
Port = get_stream_port(Config),

0 commit comments

Comments
 (0)