Fix rabbitmq/rabbitmq-packaging#49 #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes unwanted service startup after installation when the systemd service unit is disabled by a systemd preset. With compat 12 `--skip-systemd-native` is now passed to invoke-rc.d. Removed `--with systemd` since it was removed since compat 11 - see https://manpages.debian.org/bookworm/debhelper/debhelper-compat-upgrade-checklist.7.en.html Tested by building the package on Debian 12 with debhelper version 13.11.4. Should theoretically work with debhelper 11.4 or later, according to debhelper changelog at https://launchpad.net/debian/+source/debhelper/11.4
kaistierl
force-pushed
the
debian12_fix_service_autostart
branch
from
a9a975a to
c601a5b
Compare
Collaborator
|
I'm testing this out in my own Debian 12 env. Thanks. |
lukebakken
approved these changes
Apr 17, 2024
Collaborator
lukebakken
left a comment
lukebakken
left a comment
There was a problem hiding this comment.
This worked perfectly in my environment 👍
Contributor
|
@kaistierl thank you for contributing I suspect that setting was added a while ago when systemd was a fairly new development in Debian. Can you think of any risks around adopting this change? |
Contributor
I guess #49 mostly answers my questions. |
michaelklishin
approved these changes
Apr 18, 2024
Contributor
|
@Mergifyio backport v3.13.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
Fixes unwanted service startup after installation when the systemd service unit is disabled by a systemd preset. With compat 12
--skip-systemd-nativeis now passed to update-rc.d.Removed
--with systemdsince it was removed since compat 11 - see https://manpages.debian.org/bookworm/debhelper/debhelper-compat-upgrade-checklist.7.en.htmlTested by building the package on Debian 12 with debhelper version 13.11.4. Should theoretically work with debhelper 11.4 or later, according to debhelper changelog at https://launchpad.net/debian/+source/debhelper/11.4