Skip to content

Conversation

@tleperou
Copy link
Contributor

@tleperou tleperou commented Apr 10, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

  • expose the state outside of the Root
  • add support to multiple visible item per page
  • add netflix example
  • shorten the public api

Use cases and why

Anywhere users want to use Carousel to display several items.

Screenshots/Demo

image

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@gioboa
Copy link
Contributor

gioboa commented Apr 10, 2023

Thanks for your help. I tested the carousel and with Chrome I have this strange effect
https://www.loom.com/share/3b0d4367cbba4b7e8984510cc60a1301
🤔

@tleperou tleperou changed the title 253 add carousel component WIP 253 add carousel component Apr 11, 2023
@tleperou
Copy link
Contributor Author

I improved the example. And couldn't reproduce the same behaviour.

Could you confirm your still that bahviour?

(tested on Chrome and Arc at the moment)

🙌

@gioboa
Copy link
Contributor

gioboa commented Apr 11, 2023

I improved the example. And couldn't reproduce the same behaviour.

Could you confirm your still that bahviour?

(tested on Chrome and Arc at the moment)

🙌

I still have some weird flaws 🤔

@tleperou
Copy link
Contributor Author

Could you take a screen record with your mouse and keyboard indicators on ? (I think there's this option in the screen recorder)

@tleperou tleperou force-pushed the 253-add-carousel-component branch from 5db91e9 to 6823074 Compare April 12, 2023 21:51
@shairez
Copy link
Contributor

shairez commented Apr 28, 2023

based on #258 ... can we close this one @tleperou ? is it the same component?

@tleperou
Copy link
Contributor Author

tleperou commented May 4, 2023

that the same component,

this MR comes with some improvements about

  • the abstraction with the feature / styles (as seen in the doc)
  • the support of the auto (one or many slides per view)
  • the overall accessibility level

It shall be for tested again since @gioboa found weird behaviours with the auto mode (that I couldn't reproduce)

@shairez
Copy link
Contributor

shairez commented May 6, 2023

thanks @tleperou

@gioboa can you please merge this during you and @itaim18 's session?

@gioboa
Copy link
Contributor

gioboa commented May 6, 2023

thanks @tleperou

@gioboa can you please merge this during you and @itaim18 's session?

Yep sure

@nx-cloud
Copy link

nx-cloud bot commented May 7, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f63831a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@gioboa gioboa merged commit 396aeb1 into qwikifiers:main May 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants