Skip to content

Conversation

@riccardo-vettore
Copy link
Contributor

@riccardo-vettore riccardo-vettore commented Feb 24, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Add new loading indicator component

Use cases

<LoadingIndicator
      style="font-size: 3rem"
      width="10px"
      indicatorColor="darkblue"
      trackColor="lightblue"
      speed="4s"
></LoadingIndicator>

Screenshots/Demo

image

@gioboa
Copy link
Contributor

gioboa commented Feb 24, 2023

I'm thinking if loading-indicator is the right name.
I checked angular material and they call this component spinner https://material.angular.io/components/progress-spinner/overview
What do you think about this?

@riccardo-vettore
Copy link
Contributor Author

Yes, I agree, this component should be called spinner.

@gilf
Copy link
Contributor

gilf commented Feb 25, 2023

Yes, I agree, this component should be called spinner.

Agree with @gioboa. The component should be called Spinner. Once you change the name, we will merge it :)

@gioboa
Copy link
Contributor

gioboa commented Feb 25, 2023

Great work. Thanks

@gioboa gioboa merged commit 923fd4e into qwikifiers:main Feb 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2023
@gioboa
Copy link
Contributor

gioboa commented Feb 25, 2023

Closes #133

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants