From 3923f0df76d24b73d57f15eec61ab190ea048093 Mon Sep 17 00:00:00 2001 From: "Matthew \"strager\" Glazar" Date: Thu, 26 Oct 2023 18:08:30 -0400 Subject: [PATCH] fix(build): fix installing build tools for cross-compilation 'cmake --install . --component build-tools' copies no files [1]. This was caused by commit 1f2e1a47 where the code calling install() became dead code on accident. Call install() so that 'cmake --install' copies the build artifacts as intended. [1] https://github.com/quick-lint/quick-lint-js/issues/1099 Refs: 1f2e1a4701793cac24eaac44d7af81a8b820b1bc --- docs/CHANGELOG.md | 7 +++++++ tools/CMakeLists.txt | 1 - 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 65509b49fd..1d261588e8 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -6,6 +6,13 @@ based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). quick-lint-js' version numbers are arbitrary. quick-lint-js does *not* adhere to Semantic Versioning. +## Unreleased + +### Fixed + +* `cmake --install` with `--component build-tools` now installs the build + tools. (This is a regression introduced in quick-lint-js version 2.16.0.) + ## 2.17.0 (2023-10-25) [Downloads](https://c.quick-lint-js.com/releases/2.17.0/) diff --git a/tools/CMakeLists.txt b/tools/CMakeLists.txt index 71ccbdf1b8..b541afb528 100644 --- a/tools/CMakeLists.txt +++ b/tools/CMakeLists.txt @@ -68,7 +68,6 @@ if (QUICK_LINT_JS_ENABLE_BUILD_TOOLS) COMMENT "Building all quick-lint-js build-time tools" DEPENDS ${QUICK_LINT_JS_BUILD_TOOL_TARGETS} ) -elseif (QUICK_LINT_JS_ENABLE_BUILD_TOOLS) install( TARGETS ${QUICK_LINT_JS_BUILD_TOOL_TARGETS} COMPONENT build-tools