From 3464381a322ede0bdfdcd113013530a53be1cf06 Mon Sep 17 00:00:00 2001 From: Pavol Juhas Date: Thu, 19 Sep 2024 17:01:55 -0700 Subject: [PATCH 1/2] Exclude conftest.py files from enforcing changed-code coverage Avoid spurious CI failure due to missing coverage of changed conftest.py lines. conftest.py configures the pytest session. It is tricky and not worthwhile to ensure it is test-covered. --- dev_tools/incremental_coverage.py | 1 + 1 file changed, 1 insertion(+) diff --git a/dev_tools/incremental_coverage.py b/dev_tools/incremental_coverage.py index 044ac8e8411..22d6a1ac97c 100644 --- a/dev_tools/incremental_coverage.py +++ b/dev_tools/incremental_coverage.py @@ -20,6 +20,7 @@ from dev_tools import env_tools, shell_tools IGNORED_FILE_PATTERNS = [ + r'^(.+/)?conftest\.py$' r'^dev_tools/.+', # Environment-heavy code. r'^.+_pb2(_grpc)?\.py$', # Auto-generated protobuf code. r'^(.+/)?setup\.py$', # Installation code. From 325a88bdecaddfb874da15edcc8e6f6c22ce2c74 Mon Sep 17 00:00:00 2001 From: Pavol Juhas Date: Thu, 19 Sep 2024 17:30:18 -0700 Subject: [PATCH 2/2] Typo - missing comma --- dev_tools/incremental_coverage.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev_tools/incremental_coverage.py b/dev_tools/incremental_coverage.py index 22d6a1ac97c..ba004fe7667 100644 --- a/dev_tools/incremental_coverage.py +++ b/dev_tools/incremental_coverage.py @@ -20,7 +20,7 @@ from dev_tools import env_tools, shell_tools IGNORED_FILE_PATTERNS = [ - r'^(.+/)?conftest\.py$' + r'^(.+/)?conftest\.py$', r'^dev_tools/.+', # Environment-heavy code. r'^.+_pb2(_grpc)?\.py$', # Auto-generated protobuf code. r'^(.+/)?setup\.py$', # Installation code.