Skip to content

test_calc_multifactor only uses a single factor #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humdings opened this issue Jul 27, 2015 · 2 comments
Closed

test_calc_multifactor only uses a single factor #89

humdings opened this issue Jul 27, 2015 · 2 comments
Labels

Comments

@humdings
Copy link
Contributor

test_calc_multifactor and test_multifactor_beta only have a single factor passed to them. These tests should be made more robust. Anybody opposed to keeping a small csv of test data, or we can use random data with a fixed seed, thoughts?

@humdings humdings added the bug label Jul 27, 2015
@gusgordon
Copy link
Contributor

It's a good idea, but I think these functions should get deprecated in the future in favor of having some flexible beta calculation function.

@humdings
Copy link
Contributor Author

Sounds good, I think this PR is a step towards better regression methods but we will still need better tests either way.
#63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants