Skip to content

QCLINUX: defconfig: Enable Trusted Execution Environment (TEE) driver ... #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shashim-quic merged 1 commit into from
Aug 13, 2025
Merged

QCLINUX: defconfig: Enable Trusted Execution Environment (TEE) driver ... #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions arch/arm64/configs/defconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1670,6 +1670,7 @@ CONFIG_FPGA_REGION=m
CONFIG_OF_FPGA_REGION=m
CONFIG_TEE=y
CONFIG_OPTEE=y
CONFIG_QCOMTEE=y
Copy link
Collaborator

@shashim-quic shashim-quic Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPTEE and QCOMTEE cannot exist together ? How do we plan to support pristine upstream builds on our targets in that case ?

Copy link

@vksharma-oss vksharma-oss Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are @shashim-quic OPTEE and QCOMTEE both cannot exit together in system.
Here : OPTEE ---> OPTEEOS where is QCOMTEE <---->QTEE OS . In a given target either OPTEE will be enabled or QTEE will be enabled.

Copy link
Collaborator

@shashim-quic shashim-quic Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are @shashim-quic OPTEE and QCOMTEE both cannot exit together in system. Here : OPTEE ---> OPTEEOS where is QCOMTEE <---->QTEE OS . In a given target either OPTEE will be enabled or QTEE will be enabled.

then how do we support pristine upstream builds ? (assuming QCOMTEE won't be enabled there)

Copy link
Author

@jiaxli-QC jiaxli-QC Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the information on QLI Kernel Mainline Definition, adding CONFIG_QCOMTEE to qcom_addons.config helps keep the build process clean and prevents unnecessary driver conflicts. Since the QCOMTEE driver only needs to be enabled on the QCOM Platform, this approach is more suitable for us.

However, I searched the entire kernel tree in the /teck/all/configure branch but couldn't find a configuration for the custom build variant. Could you share the strategies for working with the /teck/all/configure branch? Many thanks

Copy link
Collaborator

@shashim-quic shashim-quic Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the information on QLI Kernel Mainline Definition, adding CONFIG_QCOMTEE to qcom_addons.config helps keep the build process clean and prevents unnecessary driver conflicts. Since the QCOMTEE driver only needs to be enabled on the QCOM Platform, this approach is more suitable for us.

However, I searched the entire kernel tree in the /teck/all/configure branch but couldn't find a configuration for the custom build variant. Could you share the strategies for working with the /teck/all/configure branch? Many thanks

There is no separate custom configuration, please refer http://go/qlikernelmainline which captures major policy requirements from kernel

  • single kernel image for all targets and variants
  • support for clean overlay (via DLKMs and distro configurations like blacklisting)

QCOMTEE in my opinion is not a downstream addition but an upstream one. My question is how are you planning to support QCOMTEE in upstream builds for QC platforms ?

Copy link
Collaborator

@shashim-quic shashim-quic Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The QCOMTEE driver has been merged into the kernel topic branch. #121 Currently, both QCOMTEE and OPTEE are present in the kernel topic branch, and we control which TEE driver is compiled through the defconfig. We plan to enable QCOMTEE instead of OPTEE for the upstream build by applying this patch.

May be I am not clear. What I mean is - how would upstream builds with upstream arch/arm64/configs/defconfig work on qcom targets.

Please note that all KLM targets are being tested in community kernel CI as well. Without QCOM TEE enabled in upstream defconfig, what would be the impact ?

Copy link

@vksharma-oss vksharma-oss Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shashim-quic ,
so in that case we can have optee as it enabled and make qcomtee also 1.
CONFIG_OPTEE=y
CONFIG_QCOMTEE=y

we can have both driver in place simultaneously.

Copy link

@vksharma-oss vksharma-oss Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiaxli-QC , Please update the enablement as
CONFIG_OPTEE=y
CONFIG_QCOMTEE=y

Copy link
Author

@jiaxli-QC jiaxli-QC Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Author

@jiaxli-QC jiaxli-QC Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both OPTEE and QCOMTEE drivers can be used at the same time. Since they use different CMD IDs, they will not affect each other.
All the test cases have passed.

CONFIG_MUX_GPIO=m
CONFIG_MUX_MMIO=y
CONFIG_SLIMBUS=m
Expand Down