From 08277d3bffd79efc60383b9db8213d76315024bd Mon Sep 17 00:00:00 2001 From: nighca Date: Wed, 22 Nov 2017 14:58:10 +0800 Subject: [PATCH 1/2] use LABEL instead of MAINTAINER for Dockerfile --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 24350b2..3b1b477 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,5 +1,5 @@ FROM node:6.9.1 -MAINTAINER nighca "nighca@live.cn" +LABEL maintainer="nighca@live.cn" WORKDIR /fec From 014e5cf9419b1a79c7072dd148424547ce0eba2e Mon Sep 17 00:00:00 2001 From: nighca Date: Wed, 22 Nov 2017 14:58:34 +0800 Subject: [PATCH 2/2] disable host check for dev server --- lib/serve.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/serve.js b/lib/serve.js index 767de98..16b70b8 100644 --- a/lib/serve.js +++ b/lib/serve.js @@ -10,7 +10,15 @@ const serve = port => getWebpackConfig().then( webpackConfig => { const host = '0.0.0.0' const webpackDevServerConfig = _.extend( - {}, webpackConfig.devServer, { host, port } + {}, webpackConfig.devServer, { + host, + port, + // TODO: use false as default value? + // for there may be security risk + // https://github.com/webpack/webpack-dev-server/issues/882 + // https://webpack.js.org/configuration/dev-server/#devserver-disablehostcheck + disableHostCheck: true + } ) WebpackDevServer.addDevServerEntrypoints(webpackConfig, webpackDevServerConfig)