Skip to content

Commit 46313e5

Browse files
committed
Fix software tests, the recently added pytest.skip was wrong
1 parent 1066478 commit 46313e5

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

tests/test_cratedb_pandas_read.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import sys
2+
13
import pandas as pd
24
import pytest
35
import sqlalchemy as sa
@@ -8,7 +10,8 @@
810
SQL_SELECT_STATEMENT = "SELECT mountain, height FROM sys.summits ORDER BY height DESC LIMIT 1;"
911

1012

11-
pytest.skip("Does not work on Python 3.7", allow_module_level=True)
13+
if sys.version_info < (3, 8):
14+
pytest.skip("Does not work on Python 3.7", allow_module_level=True)
1215

1316

1417
def test_crate_read_sql(cratedb_http_host, cratedb_http_port):

tests/test_cratedb_pandas_write.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import sys
2+
13
import pandas as pd
24
import pytest
35
import sqlalchemy as sa
@@ -9,7 +11,8 @@
911
SQL_REFRESH_STATEMENT = "REFRESH TABLE doc.foo;"
1012

1113

12-
pytest.skip("Does not work on Python 3.7", allow_module_level=True)
14+
if sys.version_info < (3, 8):
15+
pytest.skip("Does not work on Python 3.7", allow_module_level=True)
1316

1417

1518
def test_crate_to_sql(cratedb_http_host, cratedb_http_port):

0 commit comments

Comments
 (0)