From 2ba20b88eb97b976df3c62343004327fb0a11c9c Mon Sep 17 00:00:00 2001 From: Peter Yu Date: Fri, 29 Mar 2019 15:29:05 +1100 Subject: [PATCH 1/2] AFP-244: Only display pagination if there is more than one page --- packages/react-changelogs/src/components/changelog.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-changelogs/src/components/changelog.tsx b/packages/react-changelogs/src/components/changelog.tsx index 27f944a..9e7bbbf 100644 --- a/packages/react-changelogs/src/components/changelog.tsx +++ b/packages/react-changelogs/src/components/changelog.tsx @@ -169,7 +169,7 @@ export default class Changelog extends React.Component { ); }) )} - {entriesPerPage && ( + {entriesPerPage && pages.length > 1 && ( From 21860b3165caf17cb49822b278a3c9b91dee62b8 Mon Sep 17 00:00:00 2001 From: Peter Yu Date: Fri, 29 Mar 2019 15:56:32 +1100 Subject: [PATCH 2/2] AFP-244: Added unit test --- .../react-changelogs/src/__tests__/changelog.test.tsx | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/react-changelogs/src/__tests__/changelog.test.tsx b/packages/react-changelogs/src/__tests__/changelog.test.tsx index 63e9679..f94e342 100644 --- a/packages/react-changelogs/src/__tests__/changelog.test.tsx +++ b/packages/react-changelogs/src/__tests__/changelog.test.tsx @@ -100,6 +100,15 @@ describe('', () => { expect(wrapper.find(Pagination).find('button')).toHaveLength(8); }); + it('should not paginate if there is only one page', () => { + const wrapper = mount( + , + ); + + expect(wrapper.find('h3')).toHaveLength(2); + expect(wrapper.find(Pagination).exists()).toEqual(false); + }); + it('should not paginate if entriesPerPage is null', () => { const wrapper = mount( ,