Skip to content

Port transforms.Pad to prototype.transforms #5521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #5520
pmeier opened this issue Mar 3, 2022 · 3 comments · Fixed by #5621
Closed
Tracked by #5520

Port transforms.Pad to prototype.transforms #5521

pmeier opened this issue Mar 3, 2022 · 3 comments · Fixed by #5621

Comments

@pmeier
Copy link
Collaborator

pmeier commented Mar 3, 2022

cc @vfdev-5 @datumbox @bjuncek

@lezwon
Copy link
Contributor

lezwon commented Mar 8, 2022

@pmeier I'd like to take up this issue.

@datumbox
Copy link
Contributor

datumbox commented Mar 8, 2022

@lezwon Thanks for offering to help! Could you give us a bit more time to iron out some final changes on the API? This is mainly to avoid requiring too many change from you on the PR. Happy to ping you once we are done, what you think?

@pmeier Could you please mark the tracked issues as blocked until we finalize the aforementioned changes? For any PR that is outstanding, we should try and merge. Happy to chat offline too to see what's the best course of action.

@lezwon
Copy link
Contributor

lezwon commented Mar 8, 2022

@datumbox Sure. No issues :) Do let me know if there is any other issue you would like me to pick up. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants