You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#3027 uncovered that some models in torchvision are not being tested on CI for torchscript compatibility.
I believe the main reason was that scripting a model in the past could take a significant amount of time, which could make the CI timeout, so only models added in
Today, operator fusion happens during the first forward pass of the model.
We should at least check that all models support being converted to torch.jit.script. At best, we should execute the scripted model and compare the outputs with the non-scripted model, but this might introduce a lot of overhead if compilation is slow.
The text was updated successfully, but these errors were encountered:
Uh oh!
There was an error while loading. Please reload this page.
🐛 Bug
#3027 uncovered that some models in torchvision are not being tested on CI for torchscript compatibility.
I believe the main reason was that scripting a model in the past could take a significant amount of time, which could make the CI timeout, so only models added in
vision/test/test_models.py
Lines 47 to 79 in 8c28175
Today, operator fusion happens during the first forward pass of the model.
We should at least check that all models support being converted to
torch.jit.script
. At best, we should execute the scripted model and compare the outputs with the non-scripted model, but this might introduce a lot of overhead if compilation is slow.The text was updated successfully, but these errors were encountered: