Skip to content

transforms.Compose with custom transforms #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skrish13 opened this issue Aug 17, 2017 · 3 comments
Closed

transforms.Compose with custom transforms #225

skrish13 opened this issue Aug 17, 2017 · 3 comments

Comments

@skrish13
Copy link
Contributor

skrish13 commented Aug 17, 2017

In one of my custom transforms I take more than just the img/sample as input, this won't work with transforms.Compose as it's __call__() takes only 1 input. Any thoughts on getting a fix for this? Would be interested in making a PR if you guys would want it.

@skrish13 skrish13 changed the title compose transforms with custom transforms transforms.Compose with custom transforms Aug 17, 2017
@alykhantejani
Copy link
Contributor

Hi @skrish13 there is currently a discussion happening in this issue about how to evolve the transforms to allow for these use cases. I think we're close to a new design so hopefully this will be supported soon.

cc @fmassa I think we can close this issue as it is essentially a duplicate of #230

@fmassa fmassa closed this as completed Sep 3, 2017
@fmassa
Copy link
Member

fmassa commented Sep 3, 2017

Closing it and redirecting the discussion to #230.

@skrish13
Copy link
Contributor Author

skrish13 commented Sep 3, 2017

Yup, following that discussion as well. Thanks.

PS: Easy workaround for anyone facing issues like this: Just create your own Compose to mimic the flow you want, its pretty simple anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants