Skip to content

use logger in ft #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

use logger in ft #1539

merged 1 commit into from
Aug 6, 2025

Conversation

@tushar00jain
Copy link
Contributor

@tushar00jain tushar00jain commented Aug 6, 2025

Summary:

  • wasn't seeing print statements getting printed
  • the statements show up using the logger
  • also added some logging to validate the model is being split for diloco

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 6, 2025
@tushar00jain
use logger in ft
fac37b3 
Summary:
- wasn't seeing print statements getting printed
- the statements show up using the logger
- also added some logging to validate the model is being split for diloco
@tushar00jain tushar00jain merged commit a1fdd7e into pytorch:main Aug 6, 2025
8 checks passed
@tushar00jain tushar00jain deleted the pr1539 branch August 6, 2025 18:26
joellidin pushed a commit to one-covenant/torchtitan that referenced this pull request Aug 8, 2025
@tushar00jain @joellidin
use logger in ft (pytorch#1539)
96743e1 
Summary:
- wasn't seeing print statements getting printed
- the statements show up using the logger
- also added some logging to validate the model is being split for
diloco
joellidin pushed a commit to one-covenant/torchtitan that referenced this pull request Aug 8, 2025
@tushar00jain @joellidin
use logger in ft (pytorch#1539)
6f9d748 
Summary:
- wasn't seeing print statements getting printed
- the statements show up using the logger
- also added some logging to validate the model is being split for
diloco
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyu-l tianyu-l tianyu-l approved these changes

@fegin fegin Awaiting requested review from fegin fegin is a code owner

@wwwjn wwwjn Awaiting requested review from wwwjn wwwjn is a code owner

@wconstab wconstab Awaiting requested review from wconstab wconstab is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tushar00jain @tianyu-l