Skip to content

Commit 1a303b3

Browse files
authored
Add warning to compile rmsnorm (#505)
as titled, add warning to compile rmsnorm as it's not fully ready yet, i.e. this issue #497 We can remove this warning once we fix the issue
1 parent a4d88d1 commit 1a303b3

File tree

8 files changed

+12
-7
lines changed

8 files changed

+12
-7
lines changed

torchtitan/models/norms.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,11 @@ def build_norm(norm_type: str, dim: int, eps: float = 1e-6):
4343
elif norm_type == "rmsnorm":
4444
return RMSNorm(dim, eps=eps)
4545
elif norm_type == "compiled_rmsnorm":
46+
import warnings
47+
48+
warnings.warn(
49+
"compiled_rmsnorm is currently experimental and not ready to use yet."
50+
)
4651
return RMSNorm(dim, eps=eps, compile=True)
4752
elif norm_type == "fused_rmsnorm":
4853
return FusedRMSNorm(dim, eps=eps)

train_configs/debug_model.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ save_tb_folder = "tb"
2121
[model]
2222
name = "llama3"
2323
flavor = "debugmodel"
24-
norm_type = "compiled_rmsnorm" # layernorm / np_layernorm / rmsnorm / compiled_rmsnorm / fused_rmsnorm
24+
norm_type = "rmsnorm" # layernorm / np_layernorm / rmsnorm / compiled_rmsnorm / fused_rmsnorm
2525
# test tokenizer.model, for debug purpose only
2626
tokenizer_path = "./test/assets/test_tiktoken.model"
2727

train_configs/llama2_13b.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ save_tb_folder = "tb"
1818
[model]
1919
name = "llama2"
2020
flavor = "13B"
21-
norm_type = "rmsnorm" # layernorm / np_layernorm / rmsnorm / compiled_rmsnorm / fused_rmsnorm
21+
norm_type = "rmsnorm" # layernorm / np_layernorm / rmsnorm / fused_rmsnorm
2222
tokenizer_path = "./torchtitan/datasets/tokenizer/tokenizer.model"
2323

2424
[optimizer]

train_configs/llama2_70b.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ save_tb_folder = "tb"
1818
[model]
1919
name = "llama2"
2020
flavor = "70B"
21-
norm_type = "rmsnorm" # layernorm / np_layernorm / rmsnorm / compiled_rmsnorm / fused_rmsnorm
21+
norm_type = "rmsnorm" # layernorm / np_layernorm / rmsnorm / fused_rmsnorm
2222
tokenizer_path = "./torchtitan/datasets/tokenizer/tokenizer.model"
2323

2424
[optimizer]

train_configs/llama2_7b.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ save_tb_folder = "tb"
1717
[model]
1818
name = "llama2"
1919
flavor = "7B"
20-
norm_type = "rmsnorm" # layernorm / np_layernorm / rmsnorm / compiled_rmsnorm / fused_rmsnorm
20+
norm_type = "rmsnorm" # layernorm / np_layernorm / rmsnorm / fused_rmsnorm
2121
tokenizer_path = "./torchtitan/datasets/tokenizer/tokenizer.model"
2222

2323
[optimizer]

train_configs/llama3_405b.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ save_tb_folder = "tb"
1818
[model]
1919
name = "llama3"
2020
flavor = "405B"
21-
norm_type = "rmsnorm" # layernorm / np_layernorm / rmsnorm / compiled_rmsnorm / fused_rmsnorm
21+
norm_type = "rmsnorm" # layernorm / np_layernorm / rmsnorm / fused_rmsnorm
2222
tokenizer_path = "./torchtitan/datasets/tokenizer/original/tokenizer.model"
2323

2424
[optimizer]

train_configs/llama3_70b.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ save_tb_folder = "tb"
1818
[model]
1919
name = "llama3"
2020
flavor = "70B"
21-
norm_type = "rmsnorm" # layernorm / np_layernorm / rmsnorm / compiled_rmsnorm / fused_rmsnorm
21+
norm_type = "rmsnorm" # layernorm / np_layernorm / rmsnorm / fused_rmsnorm
2222
tokenizer_path = "./torchtitan/datasets/tokenizer/original/tokenizer.model"
2323

2424
[optimizer]

train_configs/llama3_8b.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ save_tb_folder = "tb"
1818
[model]
1919
name = "llama3"
2020
flavor = "8B"
21-
norm_type = "rmsnorm" # layernorm / np_layernorm / rmsnorm / compiled_rmsnorm / fused_rmsnorm
21+
norm_type = "rmsnorm" # layernorm / np_layernorm / rmsnorm / fused_rmsnorm
2222
tokenizer_path = "./torchtitan/datasets/tokenizer/original/tokenizer.model"
2323

2424
[optimizer]

0 commit comments

Comments
 (0)