Skip to content

Commit 1c989d3

Browse files
PT2 dashboard: Highlight speedup as red if a model started failing to run (#4340)
If a model used to run fine but now shows up as "0" because it started failing/we don't get results, we should highlight it as red.
1 parent 548705e commit 1c989d3

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

torchci/pages/benchmark/[suite]/[compiler]/[[...page]].tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,11 +423,18 @@ function ModelPanel({
423423
if (lCommit === rCommit) {
424424
return l >= SPEEDUP_THRESHOLD ? "" : styles.warning;
425425
} else {
426-
if (l === 0 || l === r) {
426+
// l is the new value, r is the old value
427+
428+
if (l === r) {
427429
// 0 means the model isn't run at all
428430
return "";
429431
}
430432

433+
// It didn't error in the past, but now it does error
434+
if (l === 0) {
435+
return styles.error;
436+
}
437+
431438
// Increasing more than x%
432439
if (l - r > RELATIVE_THRESHOLD * r) {
433440
return styles.ok;

0 commit comments

Comments
 (0)