Skip to content

Pin nvidia/DeepLearningExamples for waveglow ipynb #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

seemethere
Copy link
Member

@seemethere seemethere commented Jun 11, 2021

Updates to the nvidia/DeepLearningExamples repository have caused this particular notebook to start failing see NVIDIA/DeepLearningExamples#955

Originally surfaced from testing for the 1.9 release

NOTE: Currently untested since I'm hitting Github rate limits within colab trying to do a torch.hub.load I've verified that this works locally

I'm honestly a bit worried about pinning this particular notebook since the commit we have to pin to is ~2 years since they disabled importing from master directly a while ago so all of the commits in between are not as useful

Updates to this repository have caused this particular notebook to start failing see NVIDIA/DeepLearningExamples#955
@netlify
Copy link

netlify bot commented Jun 11, 2021

👷 Deploy Preview for pytorch-dot-org-preview processing.

🔨 Explore the source changes: 517696d

🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/60c2b14d9e02910007243cb6

@seemethere seemethere marked this pull request as draft June 11, 2021 00:03
@seemethere seemethere marked this pull request as ready for review June 11, 2021 00:41
Copy link
Contributor

@brianjo brianjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are OK. We should probably do a review of all the models in the hub after 1.9 anyway. Thanks!

@seemethere
Copy link
Member Author

No longer needed, fixed by pytorch/hub#204

@seemethere seemethere closed this Jun 16, 2021
@malfet malfet deleted the seemethere-patch-1 branch September 6, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants