Skip to content

Conversation

@seemethere
Copy link
Member

@seemethere seemethere commented Sep 29, 2025

Should remove errors related to not being authed for uploading benchmarking results. (example)

Note

This might have some implications on uploading H100 results, which the conditional was trying to solve for initially I guess?

Should remove errors related to not being authed for uploading benchmarking results. ([example](https://github.com/pytorch/helion/actions/runs/18103935503/job/51513673651))
@seemethere seemethere requested a review from oulgen September 29, 2025 18:34
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 29, 2025
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step isn't needed for AWS runners like H100 and A100, but it does no harm either, so LGTM!

@oulgen oulgen merged commit 32c2156 into main Sep 29, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants