From c287d2de689b5e2252b2928bde84b9e164066ef5 Mon Sep 17 00:00:00 2001 From: gasoonjia Date: Mon, 16 Jun 2025 11:54:36 -0700 Subject: [PATCH] Revert D76405701 This diff reverts D76405701 Depends on D76632995 (The context such as a Sandcastle job, Task, SEV, etc. was not provided.) Depends on D76405701 Differential Revision: [D76633014](https://our.internmc.facebook.com/intern/diff/D76633014/) [ghstack-poisoned] --- extension/module/bundled_module.cpp | 4 +--- extension/module/bundled_module.h | 11 ---------- extension/module/module.cpp | 2 -- extension/module/module.h | 21 ++----------------- extension/module/test/bundled_module_test.cpp | 2 +- 5 files changed, 4 insertions(+), 36 deletions(-) diff --git a/extension/module/bundled_module.cpp b/extension/module/bundled_module.cpp index 50dbfe69237..083aef141a0 100644 --- a/extension/module/bundled_module.cpp +++ b/extension/module/bundled_module.cpp @@ -27,8 +27,6 @@ std::unique_ptr program_data_loader( } } // namespace -namespace ET_BUNDLED_MODULE_NAMESPACE { - BundledModule::BundledModule( const void* bundled_program_ptr, std::unique_ptr memory_allocator, @@ -109,6 +107,6 @@ runtime::Error BundledModule::verify_method_outputs( return executorch::BUNDLED_PROGRAM_NAMESPACE::verify_method_outputs( *method, bundled_program_ptr_, testset_idx, rtol, atol); } -} // namespace ET_BUNDLED_MODULE_NAMESPACE + } // namespace extension } // namespace executorch diff --git a/extension/module/bundled_module.h b/extension/module/bundled_module.h index c75d83bcbad..d254a2cdcb5 100644 --- a/extension/module/bundled_module.h +++ b/extension/module/bundled_module.h @@ -10,19 +10,9 @@ #include -#ifdef USE_ATEN_LIB -#define ET_BUNDLED_MODULE_NAMESPACE bundled_module::aten -#else // !USE_ATEN_LIB -#define ET_BUNDLED_MODULE_NAMESPACE bundled_module -#endif // USE_ATEN_LIB - namespace executorch { namespace extension { -using ET_MODULE_NAMESPACE::Module; - -namespace ET_BUNDLED_MODULE_NAMESPACE { - /** * A facade class for loading bundled programs and executing methods within * them. @@ -129,6 +119,5 @@ class BundledModule : public Module { bool is_loaded_from_file_ = false; }; -} // namespace ET_BUNDLED_MODULE_NAMESPACE } // namespace extension } // namespace executorch diff --git a/extension/module/module.cpp b/extension/module/module.cpp index 3212077d2ee..721e9e5b89e 100644 --- a/extension/module/module.cpp +++ b/extension/module/module.cpp @@ -36,7 +36,6 @@ namespace executorch { namespace extension { -namespace ET_MODULE_NAMESPACE { using ET_RUNTIME_NAMESPACE::MethodMeta; using ET_RUNTIME_NAMESPACE::Program; @@ -309,6 +308,5 @@ runtime::Error Module::set_output( output_tensor.mutable_data_ptr(), output_tensor.nbytes(), output_index); } -} // namespace ET_MODULE_NAMESPACE } // namespace extension } // namespace executorch diff --git a/extension/module/module.h b/extension/module/module.h index b7ccaacc516..c3c8839d510 100644 --- a/extension/module/module.h +++ b/extension/module/module.h @@ -16,12 +16,6 @@ #include -#ifdef USE_ATEN_LIB -#define ET_MODULE_NAMESPACE module::aten -#else // !USE_ATEN_LIB -#define ET_MODULE_NAMESPACE module -#endif // USE_ATEN_LIB - namespace executorch { namespace extension { @@ -30,9 +24,6 @@ using ET_RUNTIME_NAMESPACE::MethodMeta; using ET_RUNTIME_NAMESPACE::NamedDataMap; using ET_RUNTIME_NAMESPACE::Program; -class ExecuTorchJni; - -namespace ET_MODULE_NAMESPACE { /** * A facade class for loading programs and executing methods within them. */ @@ -508,10 +499,9 @@ class Module { protected: std::unordered_map methods_; - friend class executorch::extension::ExecuTorchJni; + friend class ExecuTorchJni; }; -} // namespace ET_MODULE_NAMESPACE } // namespace extension } // namespace executorch @@ -519,13 +509,6 @@ namespace torch { namespace executor { // TODO(T197294990): Remove these deprecated aliases once all users have moved // to the new `::executorch` namespaces. -using ::executorch::extension::ET_MODULE_NAMESPACE::Module; +using ::executorch::extension::Module; } // namespace executor } // namespace torch - -namespace executorch { -namespace extension { -// backward compatible namespace alias -using ::executorch::extension::ET_MODULE_NAMESPACE::Module; -} // namespace extension -} // namespace executorch diff --git a/extension/module/test/bundled_module_test.cpp b/extension/module/test/bundled_module_test.cpp index 0009c15d69e..a07c5dd5486 100644 --- a/extension/module/test/bundled_module_test.cpp +++ b/extension/module/test/bundled_module_test.cpp @@ -9,7 +9,7 @@ #include #include -using namespace ::executorch::extension::ET_BUNDLED_MODULE_NAMESPACE; +using namespace ::executorch::extension; using namespace ::executorch::runtime; class BundledModuleTest : public ::testing::Test {