Skip to content

Commit 81f5b73

Browse files
committed
Unbreak optimized kernels build (and check it in unittest-buck)
Found a missing buck dep on import to internal repo. ghstack-source-id: d970722 ghstack-comment-id: 2715647590 Pull Request resolved: #9159
1 parent 8f7bc8d commit 81f5b73

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

.ci/scripts/unittest-buck2.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@ buck2 query "//backends/apple/... + //backends/example/... + \
1717
//kernels/optimized/... + //kernels/portable/... + //kernels/quantized/... + \
1818
//kernels/test/... + //runtime/... + //schema/... + //test/... + //util/..."
1919

20+
UNBUILDABLE_OPTIMIZED_OPS_REGEX="gelu|fft_r2c|log_softmax"
21+
BUILDABLE_OPTIMIZED_OPS=$(buck2 query //kernels/optimized/cpu/... | grep -E -v $UNBUILDABLE_OPTIMIZED_OPS_REGEX)
2022
# TODO: expand the covered scope of Buck targets.
2123
# //runtime/kernel/... is failing because //third-party:torchgen_files's shell script can't find python on PATH.
2224
# //runtime/test/... requires Python torch, which we don't have in our OSS buck setup.
23-
buck2 test //kernels/portable/... //runtime/backend/... //runtime/core/... \
25+
buck2 test $BUILDABLE_OPTIMIZED_OPS //kernels/portable/... //runtime/backend/... //runtime/core/... \
2426
//runtime/executor: //runtime/kernel/... //runtime/platform/...

kernels/optimized/lib_defs.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,7 @@ def define_libs(is_fbcode=False):
234234
exported_deps = [
235235
"//executorch/kernels/optimized:libutils",
236236
"//executorch/runtime/core/exec_aten:lib",
237+
"//executorch/runtime/kernel:thread_parallel_interface",
237238
],
238239
**get_apple_framework_deps_kwargs(is_fbcode),
239240
)

0 commit comments

Comments
 (0)