Use /xjd instead of /sl when dealing with symlink on Windows

huydhn · huydhn · commit e0399f017be3 · 2023-05-04T13:53:10.000-07:00
https://superuser.com/questions/1642106/how-does-robocopy-handle-file-system-links-symbolic-links-hard-links-and-junct
diff --git a/windows/internal/clone.bat b/windows/internal/clone.bat
@@ -7,7 +7,10 @@ if exist "%NIGHTLIES_PYTORCH_ROOT%" (
       rmdir /s /q pytorch
     )
     :: https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/robocopy
-    robocopy "%NIGHTLIES_PYTORCH_ROOT%" pytorch\ /e /np /nfl /sl
+    :: Without symlink handling, robocopy could get into an infinite loop with ittapi. With /sl,
+    :: symlink is ignored so functorch/docs/source/notebooks won't work. The correct option is
+    :: /xj to exclude junction point (what the heck does that even mean Microsoft?)
+    robocopy "%NIGHTLIES_PYTORCH_ROOT%" pytorch\ /e /np /nfl /xjd
     cd pytorch
 )
 if exist "%NIGHTLIES_PYTORCH_ROOT%" goto submodule

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,10 @@ if exist "%NIGHTLIES_PYTORCH_ROOT%" (`
`7`	`7`	`rmdir /s /q pytorch`
`8`	`8`	`)`
`9`	`9`	`:: https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/robocopy`
`10`		`- robocopy "%NIGHTLIES_PYTORCH_ROOT%" pytorch\ /e /np /nfl /sl`
	`10`	`+ :: Without symlink handling, robocopy could get into an infinite loop with ittapi. With /sl,`
	`11`	`+ :: symlink is ignored so functorch/docs/source/notebooks won't work. The correct option is`
	`12`	`+ :: /xj to exclude junction point (what the heck does that even mean Microsoft?)`
	`13`	`+ robocopy "%NIGHTLIES_PYTORCH_ROOT%" pytorch\ /e /np /nfl /xjd`
`11`	`14`	`cd pytorch`
`12`	`15`	`)`
`13`	`16`	`if exist "%NIGHTLIES_PYTORCH_ROOT%" goto submodule`