Skip to content

Commit da779da

Browse files
authored
Minor tweak to fbgemmgpu version to ignore RC suffix (#1694)
1 parent 3d302ee commit da779da

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

release/promote.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,13 @@ TORCHAUDIO_VERSION=${TORCHAUDIO_VERSION:-2.1.1}
1212
TORCHTEXT_VERSION=${TORCHTEXT_VERSION:-0.16.1}
1313
TORCHDATA_VERSION=${TORCHDATA_VERSION:-0.7.1}
1414
TORCHREC_VERSION=${TORCHREC_VERSION:-0.6.0}
15-
FBGEMMGPU_VERSION=${FBGEMMGPU_VERSION:-0.6.0}
15+
16+
# NB: FBGEMMGPU uses the practice of keeping rc version in the filename, i.e.
17+
# fbgemm_gpu-0.6.0rc1+cpu-cp311-cp311. On the other hand, its final RC will
18+
# be without rc suffix, fbgemm_gpu-0.6.0+cpu-cp311-cp311, and that's the one
19+
# ready to be promoted. So, keeping a + here in the version name allows the
20+
# promote script to find the correct binaries
21+
FBGEMMGPU_VERSION=${FBGEMMGPU_VERSION:-0.6.0+}
1622

1723
DRY_RUN=${DRY_RUN:-enabled}
1824

release/release_versions.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,10 @@ TORCHAUDIO_VERSION=${TORCHAUDIO_VERSION:-2.2.0}
77
TORCHTEXT_VERSION=${TORCHTEXT_VERSION:-0.17.0}
88
TORCHDATA_VERSION=${TORCHDATA_VERSION:-0.7.1}
99
TORCHREC_VERSION=${TORCHREC_VERSION:-0.6.0}
10-
FBGEMMGPU_VERSION=${FBGEMMGPU_VERSION:-0.6.0}
10+
11+
# NB: FBGEMMGPU uses the practice of keeping rc version in the filename, i.e.
12+
# fbgemm_gpu-0.6.0rc1+cpu-cp311-cp311. On the other hand, its final RC will
13+
# be without rc suffix, fbgemm_gpu-0.6.0+cpu-cp311-cp311, and that's the one
14+
# ready to be promoted. So, keeping a + here in the version name allows the
15+
# promote script to find the correct binaries
16+
FBGEMMGPU_VERSION=${FBGEMMGPU_VERSION:-0.6.0+}

0 commit comments

Comments
 (0)