Skip to content

Commit cd257e9

Browse files
authored
Fix validation workflow on aarch64 with conda 23.11.0 and GLIBC_2.25 (#1645)
* Debug aarch64 clone * Debug * Fix validation workflow with conda 23.11.0 and GLIBC_2.25 * Gate the change on linux-aarch64 and keep the old LD_LIBRARY_PATH * Try to unset LD_LIBRARY_PATH in the workflow instead * Fix copy/paste typo
1 parent df2d4e8 commit cd257e9

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

.github/workflows/validate-aarch64-linux-binaries.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,5 +95,11 @@ jobs:
9595
printf '%s\n' ${{ toJson(inputs.release-matrix) }} > release_matrix.json
9696
eval "$(conda shell.bash hook)"
9797
98-
# Standart case: Validate binaries
98+
# NB: The latest conda 23.11.0 pulls in some dependencies of conda-libmamba-solver that
99+
# require GLIBC_2.25, which is not available in the current aarch64 image causing the
100+
# subsequence git command to fail. Basically, they don't work with CentOS 7 which AML 2
101+
# is based on https://github.com/ContinuumIO/anaconda-issues/issues/12822
102+
unset LD_LIBRARY_PATH
103+
104+
# Standard case: Validate binaries
99105
source ./.github/scripts/validate_binaries.sh

test/smoke_test/smoke_test.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,16 @@ def smoke_test_modules():
258258
if module["repo"]:
259259
if not os.path.exists(f"{cwd}/{module['repo_name']}"):
260260
print(f"Path does not exist: {cwd}/{module['repo_name']}")
261-
subprocess.check_output(f"git clone --depth 1 {module['repo']}", stderr=subprocess.STDOUT, shell=True)
261+
try:
262+
subprocess.check_output(
263+
f"git clone --depth 1 {module['repo']}",
264+
stderr=subprocess.STDOUT,
265+
shell=True,
266+
)
267+
except subprocess.CalledProcessError as exc:
268+
raise RuntimeError(
269+
f"Cloning {module['repo']} FAIL: {exc.returncode} Output: {exc.output}"
270+
) from exc
262271
try:
263272
smoke_test_command = f"python3 {module['smoke_test']}"
264273
if target_os == 'windows':

0 commit comments

Comments
 (0)