Skip to content

Commit 64281f4

Browse files
committed
evaluate the fix from #1231
1 parent 2d8c841 commit 64281f4

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

.github/workflows/validate-repackaged-binary-sizes.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,20 @@ jobs:
2121
whl:
2222
- url: https://download.pytorch.org/whl/test/cu117_pypi_cudnn/torch-1.13.1%2Bcu117.with.pypi.cudnn-cp310-cp310-linux_x86_64.whl
2323
python: "3.10"
24-
# - url: https://download.pytorch.org/whl/test/cu117_pypi_cudnn/torch-1.13.1%2Bcu117.with.pypi.cudnn-cp311-cp311-linux_x86_64.whl
25-
# python: "3.11"
2624
- url: https://download.pytorch.org/whl/test/cu117_pypi_cudnn/torch-1.13.1%2Bcu117.with.pypi.cudnn-cp37-cp37m-linux_x86_64.whl
2725
python: "3.7"
2826
- url: https://download.pytorch.org/whl/test/cu117_pypi_cudnn/torch-1.13.1%2Bcu117.with.pypi.cudnn-cp38-cp38-linux_x86_64.whl
2927
python: "3.8"
3028
- url: https://download.pytorch.org/whl/test/cu117_pypi_cudnn/torch-1.13.1%2Bcu117.with.pypi.cudnn-cp39-cp39-linux_x86_64.whl
3129
python: "3.9"
30+
# - url: https://download.pytorch.org/whl/test/cu117_pypi_cudnn/torch-1.13.1%2Bcu117.with.pypi.cudnn-cp311-cp311-linux_x86_64.whl
31+
# python: "3.11"
3232

3333
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
3434
with:
3535
runner: linux.4xlarge.nvidia.gpu
36-
repository: "pytorch/builder"
37-
ref: ${{ github.ref }}
3836
job-name: "Validate binary size"
37+
upload-artifact: pipy_wheel
3938
script: |
4039
set -ex
4140
export ENV_NAME="conda-env-${{ github.run_id }}"
@@ -66,6 +65,9 @@ jobs:
6665
NEW_FILENAME=$(ls -1 *.whl | head -n 1)
6766
echo "::notice:: $FILENAME before: $SIZE_BEFORE after: $(du -h $NEW_FILENAME | cut -f1)"
6867
68+
# cp to ${RUNNER_ARTIFACT_DIR}
69+
cp $NEW_FILENAME ${RUNNER_ARTIFACT_DIR}/
70+
6971
# create conda env
7072
conda create -y -n $ENV_NAME python=$DESIRED_PYTHON
7173
conda activate $ENV_NAME

release/pypi/prep_binary_for_pypi.sh

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,15 @@ for whl_file in "$@"; do
7777
find "${dist_info_folder}" -type f -exec sed -i "s!${version_with_suffix}!${version_no_suffix}!" {} \;
7878
# Moves distinfo from one with a version suffix to one without
7979
# Example: torch-1.8.0+cpu.dist-info => torch-1.8.0.dist-info
80+
81+
echo "Before moving dist_info_folder"
82+
ls -l "${whl_dir}"
83+
8084
mv "${dist_info_folder}" "${dirname_dist_info_folder}/${basename_dist_info_folder/${version_with_suffix}/${version_no_suffix}}"
85+
86+
echo "After moving dist_info_folder"
87+
ls -l "${whl_dir}"
88+
8189
cd "${whl_dir}"
8290

8391
(
@@ -95,6 +103,7 @@ for whl_file in "$@"; do
95103
fi
96104
)
97105

106+
rm -rf "${new_whl_file}"
98107
zip -qr9 "${new_whl_file}" .
99108
)
100109
done

0 commit comments

Comments
 (0)