You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
I was just playing around with improving the typing of symbolic_shapes. The PR is not "complete" but I in particular wanted to get feedback on whether or not people liked making ValueRanges Generic; it seems that distinguishing if you have an Expr ValueRange or a SympyBoolean ValueRange is a lot of trouble for downstream. Using TypeGuard, we can perform refinements on the generic parameter inside methods, although we still have to cast back to ValueRange[T] due to python/mypy#14425 (comment)
Signed-off-by: Edward Z. Yang <[email protected]>
X-link: pytorch/pytorch#118529
Approved by: https://github.com/Skylion007
Reviewed By: clee2000
Differential Revision: D53296779
Pulled By: ezyang
fbshipit-source-id: 95799914350e50aeedf1acad93d71b79cad827c8
0 commit comments