Skip to content

Conversation

@jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Sep 19, 2025

Summary:

  • removed requirement of setting VLLM_DIR environment, since benchmark is now a cli command
  • reordered the evals and summarization of results to match better with the order of model card
  • have eval_type set to all for eval.sh
  • removed benchmark serving instructions since we have simplified performance eval to just run the latency testing

Test Plan:
local manual runs achiving desired results

Reviewers:

Subscribers:

Tasks:

Tags:

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3036

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 022e3b5 with merge base 18dbe87 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2025
@jerryzh168 jerryzh168 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Sep 19, 2025
Summary:
* removed requirement of setting VLLM_DIR environment, since benchmark is now a cli command
* reordered the evals and summarization of results to match better with the order of model card

Test Plan:
local manual runs achiving desired results

Reviewers:

Subscribers:

Tasks:

Tags:
@jerryzh168 jerryzh168 force-pushed the release-scripts-more-fixes branch from 8b6ff06 to 022e3b5 Compare September 20, 2025 00:44
@jerryzh168 jerryzh168 merged commit be4203e into main Sep 22, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants