support negtive dims in flip

zewenli98 · zewenli98 · commit b0e4e5cbbea9 · 2023-12-18T13:57:52.000-08:00
diff --git a/py/torch_tensorrt/dynamo/conversion/impl/slice/ops.py b/py/torch_tensorrt/dynamo/conversion/impl/slice/ops.py
@@ -241,6 +241,7 @@ def flip(
 
     shape = input.shape
     rank = len(shape)
+    dims = get_positive_dim(dims, rank)
 
     for i in range(rank):
         if i in dims:
diff --git a/tests/py/dynamo/conversion/test_flip_aten.py b/tests/py/dynamo/conversion/test_flip_aten.py
@@ -10,12 +10,16 @@ class TestFlipConverter(DispatchTestCase):
     @parameterized.expand(
         [
             ((3,), [0]),
+            ((3,), [-1]),
             ((3, 3), [0, 1]),
+            ((3, 3), [-2, 1]),
             ((2, 3, 4), [0]),
             ((3, 3, 3), (0, 1)),
             ((2, 3, 4), [0, 1, 2]),
+            ((2, 3, 4), [-3, -2, -1]),
             ((3, 3, 3, 3), [0]),
             ((2, 3, 4, 5), [0, 1, 2, 3]),
+            ((2, 3, 4, 5), [-4, 1, -2, 3]),
         ]
     )
     def test_flip(self, shape, dims):

Original file line number	Diff line number	Diff line change
`@@ -10,12 +10,16 @@ class TestFlipConverter(DispatchTestCase):`
`10`	`10`	`@parameterized.expand(`
`11`	`11`	`[`
`12`	`12`	`((3,), [0]),`
	`13`	`+ ((3,), [-1]),`
`13`	`14`	`((3, 3), [0, 1]),`
	`15`	`+ ((3, 3), [-2, 1]),`
`14`	`16`	`((2, 3, 4), [0]),`
`15`	`17`	`((3, 3, 3), (0, 1)),`
`16`	`18`	`((2, 3, 4), [0, 1, 2]),`
	`19`	`+ ((2, 3, 4), [-3, -2, -1]),`
`17`	`20`	`((3, 3, 3, 3), [0]),`
`18`	`21`	`((2, 3, 4, 5), [0, 1, 2, 3]),`
	`22`	`+ ((2, 3, 4, 5), [-4, 1, -2, 3]),`
`19`	`23`	`]`
`20`	`24`	`)`
`21`	`25`	`def test_flip(self, shape, dims):`